Skip to content

fix(nano): allow fallback-related types on OCBs#1339

Merged
glevco merged 1 commit intomasterfrom
fix/nano/missing-ocb-types
Jul 31, 2025
Merged

fix(nano): allow fallback-related types on OCBs#1339
glevco merged 1 commit intomasterfrom
fix/nano/missing-ocb-types

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jul 30, 2025

Motivation

Some types are required to implement the fallback method, and they were not allowed on OCB imports. This PR fixes this.

Acceptance Criteria

  • Allow fallback-related types on OCBs (NCArgs, NCRawArgs, NCParsedArgs).
    • Move those types from runner.types to nanocontracts.types.
  • Add test for calling the fallback as as internal method.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 30, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners July 30, 2025 04:26
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Jul 30, 2025
@github-actions
Copy link

github-actions bot commented Jul 30, 2025

🐰 Bencher Report

Branchfix/nano/missing-ocb-types
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.68 m
(+2.41%)Baseline: 1.64 m
1.48 m
(87.88%)
1.80 m
(93.10%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.62%. Comparing base (1927f37) to head (c8baf05).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1339      +/-   ##
==========================================
- Coverage   85.66%   85.62%   -0.04%     
==========================================
  Files         424      424              
  Lines       32120    32119       -1     
  Branches     4997     4997              
==========================================
- Hits        27516    27503      -13     
- Misses       3604     3610       +6     
- Partials     1000     1006       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jul 30, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 30, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 31, 2025
@glevco glevco force-pushed the fix/nano/missing-ocb-types branch from c1c77fb to c8baf05 Compare July 31, 2025 15:08
@glevco glevco merged commit b6c08cd into master Jul 31, 2025
8 checks passed
@glevco glevco deleted the fix/nano/missing-ocb-types branch July 31, 2025 16:31
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 31, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 5, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants