fix(nano): allow fallback-related types on OCBs#1339
Merged
Conversation
|
| Branch | fix/nano/missing-ocb-types |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(+2.41%)Baseline: 1.64 m | 1.48 m (87.88%) | 1.80 m (93.10%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1339 +/- ##
==========================================
- Coverage 85.66% 85.62% -0.04%
==========================================
Files 424 424
Lines 32120 32119 -1
Branches 4997 4997
==========================================
- Hits 27516 27503 -13
- Misses 3604 3610 +6
- Partials 1000 1006 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Jul 30, 2025
jansegre
approved these changes
Jul 30, 2025
c1c77fb to
c8baf05
Compare
This was referenced Aug 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some types are required to implement the fallback method, and they were not allowed on OCB imports. This PR fixes this.
Acceptance Criteria
NCArgs, NCRawArgs, NCParsedArgs).runner.typestonanocontracts.types.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged