feat(nano): validate types across contracts#1334
Merged
Conversation
|
| Branch | feat/nano/types-across-contracts |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(+2.31%)Baseline: 1.64 m | 1.48 m (87.96%) | 1.80 m (93.01%) |
6cc593b to
1ef8cb4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
=======================================
Coverage 85.67% 85.68%
=======================================
Files 425 425
Lines 32164 32217 +53
Branches 5002 5016 +14
=======================================
+ Hits 27557 27604 +47
+ Misses 3605 3604 -1
- Partials 1002 1009 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
reviewed
Jul 23, 2025
1ef8cb4 to
74f5f49
Compare
msbrogli
requested changes
Jul 25, 2025
msbrogli
reviewed
Jul 25, 2025
jansegre
previously approved these changes
Jul 28, 2025
jansegre
previously approved these changes
Jul 28, 2025
efd70a4 to
14abddb
Compare
msbrogli
previously approved these changes
Jul 30, 2025
msbrogli
reviewed
Jul 30, 2025
14abddb to
19b5e1b
Compare
msbrogli
previously approved these changes
Jul 30, 2025
jansegre
previously approved these changes
Jul 31, 2025
8efece2 to
d86430e
Compare
c813c54 to
5dfea12
Compare
jansegre
approved these changes
Aug 4, 2025
5dfea12 to
f9c431a
Compare
f9c431a to
18e90a1
Compare
msbrogli
approved these changes
Aug 5, 2025
This was referenced Aug 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds protections for args and return types in calls across contracts. It resolves https://github.com/HathorNetwork/nano-hathor-core/issues/228, read its description for more details.
Acceptance Criteria
Runnerto add validation of a method's args and return types when making calls across contracts.method.py:Method, which is necessary for validating calls across contracts.ReturnOnlyto support validating the fallback method.kwargsfromCallRecordandNCCallBeginEntrysince they're now merged withargs.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged