chore: override nginx config for Nano-Testnet Bravo#1332
Merged
Conversation
|
| Branch | chore/allow-override-nginx-config |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.70 m(+3.56%)Baseline: 1.64 m | 1.48 m (86.91%) | 1.81 m (94.15%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
- Coverage 85.68% 85.63% -0.06%
==========================================
Files 427 427
Lines 32304 32305 +1
Branches 5032 5032
==========================================
- Hits 27681 27665 -16
- Misses 3607 3619 +12
- Partials 1016 1021 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Jul 23, 2025
8652a59 to
be8f481
Compare
glevco
approved these changes
Aug 7, 2025
be8f481 to
305f3eb
Compare
305f3eb to
2f27350
Compare
2f27350 to
c459a59
Compare
This was referenced Aug 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We needed to expose the
/nano_contract/logsendpoint, but only for Nano-Testnet Bravo fullnodes.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged