Skip to content

chore: override nginx config for Nano-Testnet Bravo#1332

Merged
luislhl merged 2 commits intomasterfrom
chore/allow-override-nginx-config
Aug 11, 2025
Merged

chore: override nginx config for Nano-Testnet Bravo#1332
luislhl merged 2 commits intomasterfrom
chore/allow-override-nginx-config

Conversation

@luislhl
Copy link
Contributor

@luislhl luislhl commented Jul 22, 2025

Motivation

We needed to expose the /nano_contract/logs endpoint, but only for Nano-Testnet Bravo fullnodes.

Acceptance Criteria

  • We should build a new Docker image tag in the Nano-Testnet project, which includes the endpoint
  • We should refactor the Makefile so that all our projects are easily buildable there

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@luislhl luislhl requested a review from pedroferreira1 July 22, 2025 14:47
@luislhl luislhl self-assigned this Jul 22, 2025
@luislhl luislhl moved this from Todo to In Progress (Done) in Hathor Network Jul 22, 2025
@github-actions
Copy link

github-actions bot commented Jul 22, 2025

🐰 Bencher Report

Branchchore/allow-override-nginx-config
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.70 m
(+3.56%)Baseline: 1.64 m
1.48 m
(86.91%)
1.81 m
(94.15%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.63%. Comparing base (a8366c2) to head (c459a59).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   85.68%   85.63%   -0.06%     
==========================================
  Files         427      427              
  Lines       32304    32305       +1     
  Branches     5032     5032              
==========================================
- Hits        27681    27665      -16     
- Misses       3607     3619      +12     
- Partials     1016     1021       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luislhl luislhl requested review from glevco and removed request for pedroferreira1 July 22, 2025 18:37
@luislhl luislhl moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 28, 2025
@luislhl luislhl force-pushed the chore/allow-override-nginx-config branch from 8652a59 to be8f481 Compare July 31, 2025 18:53
@luislhl luislhl force-pushed the chore/allow-override-nginx-config branch from be8f481 to 305f3eb Compare August 7, 2025 15:27
@luislhl luislhl moved this from In Review (WIP) to In Review (Done) in Hathor Network Aug 7, 2025
@luislhl luislhl enabled auto-merge (squash) August 7, 2025 15:31
@luislhl luislhl force-pushed the chore/allow-override-nginx-config branch from 305f3eb to 2f27350 Compare August 8, 2025 14:43
@luislhl luislhl force-pushed the chore/allow-override-nginx-config branch from 2f27350 to c459a59 Compare August 11, 2025 15:40
@luislhl luislhl merged commit 459ee06 into master Aug 11, 2025
8 checks passed
@luislhl luislhl deleted the chore/allow-override-nginx-config branch August 11, 2025 16:14
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Aug 11, 2025
This was referenced Aug 12, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants