Release-candidate v0.64.0-rc.1

.codecov.yml

@@ -11,7 +11,7 @@ coverage:
     project:
       default:
         # minimum coverage ratio that the commit must meet to be considered a success
-        target: 82%
+        target: 85%
         if_ci_failed: error
         only_pulls: true
 

.github/workflows/base_benchmarks.yml

@@ -22,7 +22,7 @@ jobs:
       - uses: ./.github/actions/setup-hathor-env
         name: Setup Hathor node environment
         with:
-          python: 3.11
+          python: 3.12
           os: ubuntu-22.04
       - name: Set env vars
         run: cat ./extras/benchmarking/sync_v2/.env >> $GITHUB_ENV

.github/workflows/docker.yml

@@ -23,7 +23,6 @@ jobs:
         python-impl:
           - python
         python-version:
-          - '3.10'
           - '3.11'
           - '3.12'
     steps:

.github/workflows/main.yml

@@ -23,7 +23,7 @@ jobs:
           import os
           import json
           full_matrix = {
-            'python': ['3.10', '3.11', '3.12'],
+            'python': ['3.11', '3.12'],
             # available OS's: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
             'os': ['ubuntu-22.04', 'macos-13'],
           }
@@ -83,6 +83,6 @@ jobs:
         run: poetry run make tests
       - name: Upload coverage
         uses: codecov/codecov-action@v4
-        if: matrix.python == 3.11 && startsWith(matrix.os, 'ubuntu')
+        if: matrix.python == 3.12 && startsWith(matrix.os, 'ubuntu')
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/pr_benchmarks.yml

@@ -26,7 +26,7 @@ jobs:
       - uses: ./.github/actions/setup-hathor-env
         name: Setup Hathor node environment
         with:
-          python: 3.11
+          python: 3.12
           os: ubuntu-22.04
       - name: Set env vars
         run: cat ./extras/benchmarking/sync_v2/.env >> $GITHUB_ENV

.gitignore

@@ -7,7 +7,7 @@ __pycache__/
 
 docs/_build/
 
-.coverage
+.coverage*
 cover/
 /coverage*
 
@@ -25,3 +25,8 @@ extras/docker/envvars
 
 # Nix
 .direnv/
+
+keys.json
+
+# Pycharm
+.idea

Dockerfile

@@ -1,10 +1,10 @@
-# before changing these variables, make sure the tag $PYTHON-alpine$ALPINE exists first
+# before changing these variables, make sure the tag $PYTHON-slim-$DEBIAN exists first
 # list of valid tags hese: https://hub.docker.com/_/python
-ARG PYTHON=3.11
+ARG PYTHON=3.12
 ARG DEBIAN=bullseye
 
 # stage-0: copy pyproject.toml/poetry.lock and install the production set of dependencies
-FROM python:$PYTHON-slim-$DEBIAN as stage-0
+FROM python:$PYTHON-slim-$DEBIAN AS stage-0
 ARG PYTHON
 # install runtime first deps to speedup the dev deps and because layers will be reused on stage-1
 RUN apt-get -qy update

Makefile

@@ -6,6 +6,7 @@ all: check tests
 # testing:
 
 tests_cli = tests/cli/
+tests_nano = tests/nanocontracts/ tests/tx/test_indexes_nc_history.py tests/resources/nanocontracts/
 tests_lib = $(filter-out ${tests_cli} tests/__pycache__/, $(dir $(wildcard tests/*/.)))
 tests_ci = extras/github/
 
@@ -24,6 +25,10 @@ pytest_flags = -p no:warnings --cov-report=term --cov-report=html --cov-report=x
 #--implicit-reexport
 #--no-implicit-reexport
 
+.PHONY: tests-nano
+tests-nano:
+	pytest --durations=10 --cov-report=html --cov=hathor/nanocontracts/ --cov-config=.coveragerc_full -p no:warnings $(tests_nano)
+
 .PHONY: tests-cli
 tests-cli:
 	pytest --durations=10 --cov=hathor/cli/ --cov-config=.coveragerc_full --cov-fail-under=27 -p no:warnings $(tests_cli)
@@ -42,8 +47,9 @@ tests-quick:
 
 .PHONY: tests-genesis
 tests-genesis:
-	HATHOR_TEST_CONFIG_YAML='./hathor/conf/mainnet.yml' pytest tests/tx/test_genesis.py
-	HATHOR_TEST_CONFIG_YAML='./hathor/conf/testnet.yml' pytest tests/tx/test_genesis.py
+	HATHOR_TEST_CONFIG_YAML='./hathor/conf/mainnet.yml' pytest -n0 tests/tx/test_genesis.py
+	HATHOR_TEST_CONFIG_YAML='./hathor/conf/testnet.yml' pytest -n0 tests/tx/test_genesis.py
+	HATHOR_TEST_CONFIG_YAML='./hathor/conf/nano_testnet.yml' pytest -n0 tests/tx/test_genesis.py
 
 .PHONY: tests-ci
 tests-ci:
@@ -147,3 +153,16 @@ docker-push: docker
 docker-push-aws: docker
 	docker tag $(docker_tag) 769498303037.dkr.ecr.us-east-1.amazonaws.com/fullnode:$(docker_subtag)
 	docker push 769498303037.dkr.ecr.us-east-1.amazonaws.com/fullnode:$(docker_subtag)
+
+# If you get errors similar to the one below, running `make fix-rocksdb` may fix the problem.
+#
+# Traceback (most recent call last):
+#   File "<string>", line 1, in <module>
+#   File "/<redacted>/pypoetry/virtualenvs/hathor-29FNXj3I-py3.11/lib/python3.11/site-packages/rocksdb/__init__.py", line 1, in <module>
+#     from ._rocksdb import *
+# ImportError: dlopen(/<redacted>/pypoetry/virtualenvs/hathor-29FNXj3I-py3.11/lib/python3.11/site-packages/rocksdb/_rocksdb.cpython-311-darwin.so, 0x0002): Library not loaded: /opt/homebrew/opt/rocksdb/lib/librocksdb.9.dylib
+#   Referenced from: /<redacted>/pypoetry/virtualenvs/hathor-29FNXj3I-py3.11/lib/python3.11/site-packages/rocksdb/_rocksdb.cpython-311-darwin.so
+#   Reason: tried: '/opt/homebrew/opt/rocksdb/lib/librocksdb.9.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/rocksdb/lib/librocksdb.9.dylib' (no such file), '/opt/homebrew/opt/rocksdb/lib/librocksdb.9.dylib' (no such file), '/opt/homebrew/Cellar/rocksdb/10.0.1/lib/librocksdb.9.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/Cellar/rocksdb/10.0.1/lib/librocksdb.9.dylib' (no such file), '/opt/homebrew/Cellar/rocksdb/10.0.1/lib/librocksdb.9.dylib' (no such file)
+.PHONY: fix-rocksdb
+fix-rocksdb:
+	poetry run pip uninstall -y rocksdb && poetry run pip install --no-binary :all: git+https://github.com/hathornetwork/python-rocksdb.git

docs/event-queue-feature.md

@@ -20,21 +20,19 @@ To enable the Event Queue feature, you must add this CLI option when running the
 For example:
 
 ```bash
-poetry run hathor-cli run_node --memory-storage --status 8080 --testnet --enable-event-queue
+poetry run hathor-cli run_node --temp-data --status 8080 --testnet --enable-event-queue
 ```
 
 ### First run
 
-If this is the first time your full node is running with the event queue enabled, there are 3 possibilities:
+If this is the first time your full node is running with the event queue enabled, there are 2 possibilities:
 
-1. You're running the full node using memory storage, like in the example above;
-2. You're running the full node using RocksDB storage (the default option), and
-   1. You're performing a sync from scratch, that is, you don't have an existing database, or
-   2. You're running from an existing database.
+1. You're performing a sync from scratch or you're using a temporary database (like in the example above), that is, you don't have an existing database, or
+2. You're running from an existing database.
 
-For cases 1 and 2.1, the full node will start normally, events will be generated in real time while vertices are synced, and they'll be sent to the WebSocket connection accordingly, as explained below.
+For case 1, the full node will start normally, events will be generated in real time while vertices are synced and they'll be sent to the WebSocket connection accordingly, as explained below.
 
-For case 2.2, an extra loading step will be performed during full node initialization, generating events for all existing vertices in your database. This step is slower than normal full node initialization and can take several minutes. Note that this will only be necessary once — after initialization, the events generated for your database are persisted and will be used in subsequent runs.
+For case 2, an extra loading step will be performed during full node initialization, generating events for all existing vertices in your database. This step is slower than normal full node initialization and can take several minutes. Note that this will only be necessary once — after initialization, the events generated for your database are persisted and will be used in subsequent runs.
 
 ### Subsequent runs when using RocksDB
 

extras/custom_checks.sh

@@ -58,6 +58,7 @@ function check_do_not_use_builtin_random_in_tests() {
 		hathor/merged_mining/debug_api.py
 		hathor/client.py
 		hathor/cli/tx_generator.py
+		tests/test_utils/test_leb128.py
 	)
 	exclude_params=()
 	for item in "${exclude[@]}"; do
@@ -81,9 +82,10 @@ function check_deprecated_typing() {
 }
 
 function check_do_not_import_tests_in_hathor() {
-	if grep -R '\<.*import .*tests.*\>\|\<.*from .*tests.* import\>' "hathor"; then
+	if grep -R '\<.*import .*tests.*\>\|\<.*from .*tests.* import\>' "hathor" | grep -v '# skip-import-tests-custom-check'; then
 		echo 'do not import test definitions in the hathor module'
 		echo 'move them from tests to hathor instead'
+		echo 'alternatively, comment `# skip-import-tests-custom-check` to exclude a line.'
 		return 1
 	fi
 	return 0

extras/custom_tests/side_dag/utils.py

@@ -29,11 +29,11 @@
     python -m hathor run_node_with_side_dag
         --disable-logs
         --testnet
-        --memory-storage
+        --temp-data
         --x-localhost-only
         --procname-prefix {HATHOR_PROCESS_PREFIX}
         --side-dag-testnet
-        --side-dag-memory-storage
+        --side-dag-temp-data
         --side-dag-x-localhost-only
         --side-dag-procname-prefix {SIDE_DAG_PROCESS_PREFIX}
 """

extras/github/docker.py

@@ -18,7 +18,7 @@ def prep_base_version(environ: Dict):
     ref = GITHUB_REF
 
     # Set base_version according to the github ref type
-    is_release_candidate = False
+    is_pre_release = False
     is_release = False
     is_nightly = False
 
@@ -42,9 +42,9 @@ def prep_base_version(environ: Dict):
 
         # Check if this is a release-candidate
         if pre_release:
-            if re.match(r'^rc\.[0-9]{1,3}$', pre_release):
+            if re.match(r'^(rc|alpha|beta)\.[0-9]{1,3}$', pre_release):
                 base_version = base_version + '-' + pre_release
-                is_release_candidate = True
+                is_pre_release = True
             else:
                 raise ValueError(f'Invalid Tag Value: {git_tag}')
         else:
@@ -58,18 +58,18 @@ def prep_base_version(environ: Dict):
     else:
         base_version = 'noop'
 
-    overwrite_hathor_core_version = is_release or is_release_candidate or is_nightly
+    overwrite_hathor_core_version = is_release or is_pre_release or is_nightly
     # We don't know for sure at this point in which cases we should enable Slack notification,
     # but we know when we should disable it for sure
-    output['disable-slack-notification'] = not (is_release or is_release_candidate)
+    output['disable-slack-notification'] = not (is_release or is_pre_release)
 
     if GITHUB_REPOSITORY.lower() != 'hathornetwork/hathor-core':
         output['disable-slack-notification'] = True
 
-    return output, base_version, is_release_candidate, overwrite_hathor_core_version
+    return output, base_version, is_pre_release, overwrite_hathor_core_version
 
 
-def prep_tags(environ: Dict, base_version: str, is_release_candidate: bool):
+def prep_tags(environ: Dict, base_version: str, is_pre_release: bool):
     MATRIX_PYTHON_IMPL = environ.get('MATRIX_PYTHON_IMPL')
     MATRIX_PYTHON_VERSION = environ.get('MATRIX_PYTHON_VERSION')
 
@@ -111,7 +111,7 @@ def extract_pyver(filename):
         tags.add(minor + '-' + suffix)
         if suffix == default_python:
             tags.add('latest')
-    elif GITHUB_EVENT_NAME == 'push' and not is_release_candidate:
+    elif GITHUB_EVENT_NAME == 'push' and not is_pre_release:
         tags.add('sha-' + GITHUB_SHA[:8])
 
     # Build the image list and set outputs
@@ -150,10 +150,10 @@ def overwrite_version(base_version: str):
 
 
 if __name__ == '__main__':
-    output, base_version, is_release_candidate, overwrite_hathor_core_version = prep_base_version(os.environ)
+    output, base_version, is_pre_release, overwrite_hathor_core_version = prep_base_version(os.environ)
     print_output(output)
 
-    output = prep_tags(os.environ, base_version, is_release_candidate)
+    output = prep_tags(os.environ, base_version, is_pre_release)
     print_output(output)
 
     if overwrite_hathor_core_version:

extras/github/test_docker.py

@@ -3,8 +3,8 @@
 
 from extras.github.docker import prep_base_version, prep_tags
 
-DEFAULT_PYTHON_VERSION = '3.11'
-NON_DEFAULT_PYTHON_VERSION = '3.10'
+DEFAULT_PYTHON_VERSION = '3.12'
+NON_DEFAULT_PYTHON_VERSION = '3.11'
 
 
 class DockerWorkflowTest(unittest.TestCase):

flake.nix

@@ -17,7 +17,7 @@
         in
           pkgs.mkShell {
             buildInputs = [
-              pkgs.python310
+              pkgs.python312
               pkgs.poetry
               pkgs.rocksdb
               pkgs.snappy
@@ -33,7 +33,7 @@
             shellHook = ''
               export CFLAGS="-I${pkgs.rocksdb}/include"
               export LDFLAGS="-L${pkgs.rocksdb}/lib"
-              poetry env use python3.10
+              poetry env use python3.12
             '';
           };
     });