Merged
Conversation
luislhl
changed the title
msbrogli
approved these changes
Jul 21, 2025
jansegre
approved these changes
Jul 21, 2025
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
|
Bencher Report| Branch | fix/disable-history-streaming |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.75 m(+7.09%)Baseline: 1.64 m | 1.47 m (84.04%) | 1.80 m (97.35%) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 85.59% 85.58% -0.02%
==========================================
Files 424 424
Lines 31994 31994
Branches 4971 4971
==========================================
- Hits 27386 27382 -4
Misses 3608 3608
- Partials 1000 1004 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luislhl
force-pushed
the
fix/disable-history-streaming
branch
from
a808b1f to
8e3d232
Compare
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This was referenced Aug 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is a possible bug path that could generate an infinite recursion.
It apparently doesn't manifest just because there are no connections yet when the function is called.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged