Skip to content

tests(nano): fix flaky test#1328

Merged
glevco merged 1 commit intomasterfrom
tests/nano/fix-flaky
Jul 23, 2025
Merged

tests(nano): fix flaky test#1328
glevco merged 1 commit intomasterfrom
tests/nano/fix-flaky

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jul 18, 2025

Motivation

This PR fixes the following 2 flaky tests:

  1. test_nc_consensus_success_custom_token
  2. test_nc_consensus_success

Acceptance Criteria

  • Refactor nanocontracts/test_consensus.py to better handle timestamps.
  • Refactor create_tokens on tests/utils.py to prevent it from creating invalid transactions.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 18, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners July 18, 2025 22:36
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Jul 18, 2025
@github-actions
Copy link

github-actions bot commented Jul 18, 2025

🐰 Bencher Report

Branchtests/nano/fix-flaky
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.68 m
(+2.47%)Baseline: 1.64 m
1.47 m
(87.83%)
1.80 m
(93.15%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (0faf646) to head (dd9c17e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
- Coverage   85.65%   85.59%   -0.07%     
==========================================
  Files         424      424              
  Lines       31994    31994              
  Branches     4971     4971              
==========================================
- Hits        27406    27386      -20     
- Misses       3595     3605      +10     
- Partials      993     1003      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco force-pushed the tests/nano/fix-flaky branch 2 times, most recently from 22b0455 to fad0cb1 Compare July 22, 2025 16:13
@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jul 22, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 22, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 23, 2025
@glevco glevco force-pushed the tests/nano/fix-flaky branch from fad0cb1 to 2891496 Compare July 23, 2025 17:34
@glevco glevco force-pushed the tests/nano/fix-flaky branch from 2891496 to dd9c17e Compare July 23, 2025 21:17
@glevco glevco merged commit 3c4b408 into master Jul 23, 2025
8 checks passed
@glevco glevco deleted the tests/nano/fix-flaky branch July 23, 2025 22:20
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 23, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 5, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants