Skip to content

chore(nano): remove deprecated get_balance#1327

Merged
glevco merged 1 commit intomasterfrom
chore/nano/remove-deprecated
Jul 24, 2025
Merged

chore(nano): remove deprecated get_balance#1327
glevco merged 1 commit intomasterfrom
chore/nano/remove-deprecated

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jul 18, 2025

Motivation

The get_balance syscall was deprecated in favor of the explicit methods get_current_balance and get_balance_before_current_call. This PR removes it.

Originally the task was to remove the *_before_current_call syscalls. But I gave more thought into it and I think it's good to keep them both, as it makes it clear for the user that there are different ways of interpreting the balance, and that they should choose the right one for their use case. Otherwise, it requires more knowledge of how our system works (for example, knowing when actions are executed).

Acceptance Criteria

  • Remove get_balance syscall.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 18, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners July 18, 2025 17:46
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Jul 18, 2025
@github-actions
Copy link

github-actions bot commented Jul 18, 2025

🐰 Bencher Report

Branchchore/nano/remove-deprecated
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.65 m
(+0.43%)Baseline: 1.64 m
1.47 m
(89.62%)
1.80 m
(91.30%)
🐰 View full continuous benchmarking report in Bencher

@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 22, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 22, 2025
@glevco glevco force-pushed the chore/nano/remove-deprecated branch from a087db2 to fdb12b8 Compare July 23, 2025 03:18
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.58%. Comparing base (3c4b408) to head (62d0d5b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
- Coverage   85.61%   85.58%   -0.03%     
==========================================
  Files         424      424              
  Lines       31994    31986       -8     
  Branches     4971     4967       -4     
==========================================
- Hits        27391    27375      -16     
- Misses       3606     3608       +2     
- Partials      997     1003       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco force-pushed the chore/nano/remove-deprecated branch from fdb12b8 to b6217a1 Compare July 23, 2025 15:47
@glevco glevco force-pushed the chore/nano/remove-deprecated branch from b6217a1 to 62d0d5b Compare July 23, 2025 22:21
@glevco glevco merged commit 4daccef into master Jul 24, 2025
11 of 14 checks passed
@glevco glevco deleted the chore/nano/remove-deprecated branch July 24, 2025 06:23
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 24, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 5, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants