chore(nano): remove deprecated get_balance#1327
Merged
Conversation
|
| Branch | chore/nano/remove-deprecated |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.65 m(+0.43%)Baseline: 1.64 m | 1.47 m (89.62%) | 1.80 m (91.30%) |
jansegre
approved these changes
Jul 22, 2025
msbrogli
approved these changes
Jul 22, 2025
a087db2 to
fdb12b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 85.61% 85.58% -0.03%
==========================================
Files 424 424
Lines 31994 31986 -8
Branches 4971 4967 -4
==========================================
- Hits 27391 27375 -16
- Misses 3606 3608 +2
- Partials 997 1003 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fdb12b8 to
b6217a1
Compare
b6217a1 to
62d0d5b
Compare
This was referenced Aug 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
get_balancesyscall was deprecated in favor of the explicit methodsget_current_balanceandget_balance_before_current_call. This PR removes it.Originally the task was to remove the
*_before_current_callsyscalls. But I gave more thought into it and I think it's good to keep them both, as it makes it clear for the user that there are different ways of interpreting the balance, and that they should choose the right one for their use case. Otherwise, it requires more knowledge of how our system works (for example, knowing when actions are executed).Acceptance Criteria
get_balancesyscall.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged