Skip to content

fix(events): nano scenarios on simulator when using Docker#1326

Merged
jansegre merged 1 commit intomasterfrom
fix/nano/events-simulator
Jul 21, 2025
Merged

fix(events): nano scenarios on simulator when using Docker#1326
jansegre merged 1 commit intomasterfrom
fix/nano/events-simulator

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jul 18, 2025

Motivation

When using Docker, the tests module is not copied to the image. So we cannot use imports from it in the CLI.

Acceptance Criteria

  • Remove TestDAGBuilder usage from the events_simulator CLI.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 18, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners July 18, 2025 16:59
@glevco glevco added the bug Something isn't working label Jul 18, 2025
@glevco glevco requested a review from r4mmer July 18, 2025 17:01
@glevco glevco moved this from Todo to In Review (WIP) in Hathor Network Jul 18, 2025
@github-actions
Copy link

🐰 Bencher Report

Branchfix/nano/events-simulator
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.65 m
(+0.46%)Baseline: 1.64 m
1.47 m
(89.59%)
1.80 m
(91.32%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 21, 2025
@jansegre jansegre merged commit 2731fc5 into master Jul 21, 2025
16 of 19 checks passed
@jansegre jansegre deleted the fix/nano/events-simulator branch July 21, 2025 23:24
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 21, 2025
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants