Skip to content

feat: add config for testnet-hotel#1322

Merged
glevco merged 1 commit intomasterfrom
feat/config-testnet-hotel
Jul 16, 2025
Merged

feat: add config for testnet-hotel#1322
glevco merged 1 commit intomasterfrom
feat/config-testnet-hotel

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jul 16, 2025

Motivation

Add new configs for the testnet-hotel network.

Acceptance Criteria

  • Add new testnet_hotel.yml config based on testnet.yml — the only differences are the NETWORK_NAME and BOOTSTRAP_DNS.
  • Add new --testnet-hotel CLI option.
  • Remove unnecessary config files (nano_testnet.py and unittests.py).

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 16, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners July 16, 2025 18:55
@github-actions
Copy link

github-actions bot commented Jul 16, 2025

🐰 Bencher Report

Branchfeat/config-testnet-hotel
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.62 m
(-1.01%)Baseline: 1.64 m
1.47 m
(90.92%)
1.80 m
(89.99%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the feat/config-testnet-hotel branch 2 times, most recently from d4786fc to f32ce47 Compare July 16, 2025 19:10
@glevco glevco force-pushed the feat/config-testnet-hotel branch from f32ce47 to 73e0be4 Compare July 16, 2025 19:13
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (d57a98e) to head (73e0be4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
+ Coverage   85.63%   85.64%   +0.01%     
==========================================
  Files         426      424       -2     
  Lines       31966    31962       -4     
  Branches     4963     4963              
==========================================
  Hits        27373    27373              
+ Misses       3596     3592       -4     
  Partials      997      997              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 16, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 16, 2025
@glevco glevco merged commit c8a8ba4 into master Jul 16, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 16, 2025
@glevco glevco deleted the feat/config-testnet-hotel branch July 16, 2025 21:14
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants