tests(nano): add register_blueprint_file test method#1318
Merged
Conversation
|
| Branch | tests/nano/verify-blueprint |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 2.22 m(+34.88%)Baseline: 1.64 m | 1.81 m (122.62%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 2.22 m(+34.88%)Baseline: 1.64 m | 1.48 m (66.72%) | 1.81 m (122.62%) |
c0f8e82 to
bcfdf6c
Compare
bcfdf6c to
45229e4
Compare
45229e4 to
8112ca8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1318 +/- ##
==========================================
- Coverage 85.65% 85.59% -0.07%
==========================================
Files 426 426
Lines 31966 31966
Branches 4963 4963
==========================================
- Hits 27380 27360 -20
- Misses 3590 3605 +15
- Partials 996 1001 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Jul 16, 2025
msbrogli
approved these changes
Jul 16, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When blueprint devs are implementing tests, their blueprints are not verified against code restrictions. This PR adds the
register_blueprint_filemethod which does this and should be used by blueprints devs from now on instead ofregister_blueprint_class.Acceptance Criteria
register_blueprint_classtest method to_register_blueprint_class, making the blueprint ID optional. It should be used by our internal tests.register_blueprint_filetest method, which verifies the blueprint code. It should be used by blueprint devs.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged