Skip to content

tests(nano): add register_blueprint_file test method#1318

Merged
jansegre merged 1 commit intomasterfrom
tests/nano/verify-blueprint
Jul 16, 2025
Merged

tests(nano): add register_blueprint_file test method#1318
jansegre merged 1 commit intomasterfrom
tests/nano/verify-blueprint

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jul 14, 2025

Motivation

When blueprint devs are implementing tests, their blueprints are not verified against code restrictions. This PR adds the register_blueprint_file method which does this and should be used by blueprints devs from now on instead of register_blueprint_class.

Acceptance Criteria

  • Change register_blueprint_class test method to _register_blueprint_class, making the blueprint ID optional. It should be used by our internal tests.
  • Add new register_blueprint_file test method, which verifies the blueprint code. It should be used by blueprint devs.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 14, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners July 14, 2025 16:18
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Jul 14, 2025
@github-actions
Copy link

github-actions bot commented Jul 14, 2025

🐰 Bencher Report

Branchtests/nano/verify-blueprint
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚷 threshold
🚨 alert (🔔)
2.22 m
(+34.88%)Baseline: 1.64 m
1.81 m
(122.62%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
🚨 view alert (🔔)
2.22 m
(+34.88%)Baseline: 1.64 m
1.48 m
(66.72%)
1.81 m
(122.62%)

🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the tests/nano/verify-blueprint branch 2 times, most recently from c0f8e82 to bcfdf6c Compare July 14, 2025 16:28
@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jul 14, 2025
@glevco glevco force-pushed the tests/nano/verify-blueprint branch from bcfdf6c to 45229e4 Compare July 14, 2025 16:30
@glevco glevco force-pushed the tests/nano/verify-blueprint branch from 45229e4 to 8112ca8 Compare July 16, 2025 16:29
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (bf25283) to head (8112ca8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   85.65%   85.59%   -0.07%     
==========================================
  Files         426      426              
  Lines       31966    31966              
  Branches     4963     4963              
==========================================
- Hits        27380    27360      -20     
- Misses       3590     3605      +15     
- Partials      996     1001       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 16, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 16, 2025
@jansegre jansegre merged commit d57a98e into master Jul 16, 2025
11 of 14 checks passed
@jansegre jansegre deleted the tests/nano/verify-blueprint branch July 16, 2025 19:09
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 16, 2025
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants