Skip to content

fix(nano): incorrect lower bound in _SizedIntNCType#1317

Merged
jansegre merged 1 commit intomasterfrom
fix/sized-int-lower-bound
Jul 25, 2025
Merged

fix(nano): incorrect lower bound in _SizedIntNCType#1317
jansegre merged 1 commit intomasterfrom
fix/sized-int-lower-bound

Conversation

@jansegre
Copy link
Member

Motivation

Lower bound for signed integer was incorrectly using byte-size instead of bit-size.

Acceptance Criteria

  • Fix lower bound calculation of sized signed integer serializer.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Jul 14, 2025
@jansegre jansegre requested a review from msbrogli as a code owner July 14, 2025 16:11
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Jul 14, 2025
@github-actions
Copy link

github-actions bot commented Jul 14, 2025

🐰 Bencher Report

Branchfix/sized-int-lower-bound
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.74 m
(+6.15%)Baseline: 1.64 m
1.48 m
(84.79%)
1.80 m
(96.50%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.57%. Comparing base (4daccef) to head (23eeef7).

Files with missing lines Patch % Lines
hathor/nanocontracts/nc_types/sized_int_nc_type.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   85.59%   85.57%   -0.02%     
==========================================
  Files         424      424              
  Lines       31986    31989       +3     
  Branches     4967     4967              
==========================================
- Hits        27377    27376       -1     
- Misses       3607     3610       +3     
- Partials     1002     1003       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre requested a review from glevco July 22, 2025 19:08
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 22, 2025
@jansegre jansegre force-pushed the fix/sized-int-lower-bound branch from 4edfa17 to 23eeef7 Compare July 25, 2025 14:51
glevco
glevco previously approved these changes Jul 25, 2025
@jansegre jansegre force-pushed the fix/sized-int-lower-bound branch 3 times, most recently from d81bb1c to bdc5334 Compare July 25, 2025 16:28
glevco
glevco previously approved these changes Jul 25, 2025
@jansegre jansegre dismissed glevco’s stale review July 25, 2025 16:28

The merge-base changed after approval.

@jansegre jansegre force-pushed the fix/sized-int-lower-bound branch from bdc5334 to 23de8bf Compare July 25, 2025 16:29
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 25, 2025
@jansegre jansegre merged commit 1d13b1e into master Jul 25, 2025
9 of 13 checks passed
@jansegre jansegre deleted the fix/sized-int-lower-bound branch July 25, 2025 17:50
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 25, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 5, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants