Skip to content

fix(nano): use Uint32 for Timestamp instead of Int32#1316

Merged
jansegre merged 1 commit intomasterfrom
fix/use-uint32-for-timestamp
Jul 25, 2025
Merged

fix(nano): use Uint32 for Timestamp instead of Int32#1316
jansegre merged 1 commit intomasterfrom
fix/use-uint32-for-timestamp

Conversation

@jansegre
Copy link
Member

Motivation

Timestamps don't make use of negative integers, so it's not useful to use a signed integer encoding.

Acceptance Criteria

  • Introduce Uint32NCType that is similar to Int32NCType but unsigned instead of signed
  • Change Timestamp's mapping to Uint32NCType

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Jul 14, 2025
@jansegre jansegre requested a review from msbrogli as a code owner July 14, 2025 16:00
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Jul 14, 2025
@github-actions
Copy link

github-actions bot commented Jul 14, 2025

🐰 Bencher Report

Branchfix/use-uint32-for-timestamp
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.65 m
(+0.98%)Baseline: 1.64 m
1.47 m
(89.12%)
1.80 m
(91.80%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.60%. Comparing base (4daccef) to head (c2e6138).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
+ Coverage   85.59%   85.60%   +0.01%     
==========================================
  Files         424      424              
  Lines       31986    31989       +3     
  Branches     4967     4967              
==========================================
+ Hits        27377    27385       +8     
+ Misses       3607     3606       -1     
+ Partials     1002      998       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre requested a review from glevco July 22, 2025 19:08
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jul 22, 2025
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Jul 24, 2025
@jansegre jansegre force-pushed the fix/use-uint32-for-timestamp branch from 01446ab to c2e6138 Compare July 25, 2025 13:55
@jansegre jansegre merged commit 245c906 into master Jul 25, 2025
8 checks passed
@jansegre jansegre deleted the fix/use-uint32-for-timestamp branch July 25, 2025 16:28
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jul 25, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Aug 5, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants