fix(nano): use Uint32 for Timestamp instead of Int32#1316
Merged
Conversation
|
| Branch | fix/use-uint32-for-timestamp |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.65 m(+0.98%)Baseline: 1.64 m | 1.47 m (89.12%) | 1.80 m (91.80%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
+ Coverage 85.59% 85.60% +0.01%
==========================================
Files 424 424
Lines 31986 31989 +3
Branches 4967 4967
==========================================
+ Hits 27377 27385 +8
+ Misses 3607 3606 -1
+ Partials 1002 998 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
approved these changes
Jul 22, 2025
msbrogli
approved these changes
Jul 22, 2025
01446ab to
c2e6138
Compare
This was referenced Aug 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Timestamps don't make use of negative integers, so it's not useful to use a signed integer encoding.
Acceptance Criteria
Uint32NCTypethat is similar toInt32NCTypebut unsigned instead of signedTimestamp's mapping toUint32NCTypeChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged