Conversation
f749a57 to
8cfcf43
Compare
pedroferreira1
approved these changes
Jul 10, 2025
|
| Branch | feat/check-blueprint |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.63 m(-0.52%)Baseline: 1.64 m | 1.47 m (90.47%) | 1.80 m (90.44%) |
jansegre
approved these changes
Jul 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1315 +/- ##
==========================================
- Coverage 85.63% 85.58% -0.05%
==========================================
Files 426 426
Lines 31947 31949 +2
Branches 4962 4962
==========================================
- Hits 27358 27344 -14
- Misses 3590 3604 +14
- Partials 999 1001 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8cfcf43 to
c7643e0
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement a new
check-blueprintCLI command for Blueprint devs to check the syntax validity of their Blueprints.Usage:
Acceptance Criteria
check-blueprintCLI command.verify_codemethod.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged