Merged
Conversation
jansegre
force-pushed
the
chore/add-nano-testnet-ocb-address
branch
from
7d89069 to
3add98f
Compare
|
Bencher Report| Branch | chore/add-nano-testnet-ocb-address |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.69 m(+3.22%)Baseline: 1.64 m | 1.47 m (87.19%) | 1.80 m (93.83%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
- Coverage 85.64% 85.58% -0.06%
==========================================
Files 426 426
Lines 31948 31948
Branches 4965 4965
==========================================
- Hits 27363 27344 -19
- Misses 3587 3602 +15
- Partials 998 1002 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Jul 8, 2025
We can do this because nano-testnet-bravo is not publicly live yet.
jansegre
force-pushed
the
chore/add-nano-testnet-ocb-address
branch
from
3add98f to
914d559
Compare
luislhl
approved these changes
Jul 9, 2025
github-project-automation
bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We can do this because
nano-testnet-bravois not publicly live yet.Acceptance Criteria
WQFDxic8xWWnMLL4aE5abY2XRKPNvGhtjYto allowed OCB addresses onnano-testnet-bravo's configChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged