Skip to content

chore: accept -alpha.N and -beta.N pre-release tags#1307

Merged
jansegre merged 1 commit intomasterfrom
chore/accept-alpha-beta-tags
Jun 27, 2025
Merged

chore: accept -alpha.N and -beta.N pre-release tags#1307
jansegre merged 1 commit intomasterfrom
chore/accept-alpha-beta-tags

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Jun 27, 2025

Motivation

Tags like v0.64.0-alpha.1 would fail to build an image because "alpha" is not accepted, only "rc".

Acceptance Criteria

  • Adjust the parsing of tags to accept -alpha.N and -beta.N in addition to the current -rc.N

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested a review from luislhl June 27, 2025 14:56
@jansegre jansegre self-assigned this Jun 27, 2025
@jansegre jansegre requested a review from msbrogli as a code owner June 27, 2025 14:56
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Jun 27, 2025
@github-actions
Copy link

🐰 Bencher Report

Branchchore/accept-alpha-beta-tags
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.64 m
(+0.07%)Baseline: 1.63 m
1.47 m
(89.94%)
1.80 m
(90.97%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre merged commit 85e9049 into master Jun 27, 2025
6 of 7 checks passed
@jansegre jansegre deleted the chore/accept-alpha-beta-tags branch June 27, 2025 15:19
@github-project-automation github-project-automation bot moved this from In Progress (Done) to Waiting to be deployed in Hathor Network Jun 27, 2025
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (1cba342) to head (623adbe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1307      +/-   ##
==========================================
- Coverage   85.60%   85.55%   -0.05%     
==========================================
  Files         426      426              
  Lines       31940    31940              
  Branches     4961     4961              
==========================================
- Hits        27341    27327      -14     
- Misses       3600     3607       +7     
- Partials      999     1006       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants