feat(nano): add recent changes [part 17]#1301
Merged
Conversation
glevco
commented
Jun 25, 2025
Comment on lines
+66
to
+71
| assert b12.get_metadata().voided_by is None | ||
| b12_storage = self.manager.get_nc_storage(b12, nc1.hash) | ||
|
|
||
| with self.assertRaises(KeyError): | ||
| b12_storage.get_obj(b'dc:\x03foo', INT_VARTUPLE_NC_TYPE) | ||
| assert b12_storage.get_obj(b'dc:\x03bar', INT_VARTUPLE_NC_TYPE) == (4, 5, 6, 7) |
Contributor
Author
There was a problem hiding this comment.
b12 is useless, we can remove it.
Contributor
Author
|
LGTM ✅ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
==========================================
+ Coverage 85.27% 85.56% +0.28%
==========================================
Files 426 426
Lines 31908 31940 +32
Branches 4950 4961 +11
==========================================
+ Hits 27211 27330 +119
+ Misses 3674 3604 -70
+ Partials 1023 1006 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
previously approved these changes
Jun 26, 2025
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
glevco
force-pushed
the
tests/nano/batch2
branch
from
5e54f1d to
9b71b40
Compare
jansegre
approved these changes
Jun 26, 2025
|
Bencher Report| Branch | feat/nano/part17 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(+2.66%)Baseline: 1.64 m | 1.47 m (87.67%) | 1.80 m (93.33%) |
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update master with the final changes made on nano-master during the merge process.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged