fix(cli): quick-test subcommand regression after VertexHandler refactor#1298
Merged
fix(cli): quick-test subcommand regression after VertexHandler refactor#1298
Conversation
|
Bencher Report| Branch | fix/cli-quick-test |
| Testbed | ubuntu-22.04 |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | minutes (m) |
|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot | 1.61 m |
glevco
approved these changes
Jun 9, 2025
github-project-automation
bot
moved this from In Progress (Done)
to Waiting to be deployed
in Hathor Network
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (81.44%) is below the target coverage (82.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
- Coverage 81.45% 81.44% -0.01%
==========================================
Files 373 373
Lines 26697 26697
Branches 4060 4060
==========================================
- Hits 21745 21744 -1
- Misses 4209 4210 +1
Partials 743 743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After
VertexHandlerrefactor, theVertexHandlerWrapperthat thequick_testsubcommand uses, broke.Acceptance Criteria
VertexHandlerWrapperto support the new methods;Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged