feat(p2p): Add misbehavior score for unsolicited vertices#1296
Merged
feat(p2p): Add misbehavior score for unsolicited vertices#1296
Conversation
99ebfe1 to
d0043ba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
+ Coverage 82.86% 82.90% +0.03%
==========================================
Files 362 362
Lines 25823 25838 +15
Branches 3954 3956 +2
==========================================
+ Hits 21399 21420 +21
+ Misses 3697 3691 -6
Partials 727 727 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
approved these changes
Jun 6, 2025
jansegre
approved these changes
Jun 6, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces a misbehavior score but simply close the connection when the threshold is reached. A future PR can enforce better responses to misbehavior (e.g., temporary ban for the peer id or ip address).
Acceptance Criteria
_inbound_relay_enabled: boolto control whether we request relay from the peer.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged