refactor(consensus): Split on_new_vertex() and remove fails_silently#1295
Merged
refactor(consensus): Split on_new_vertex() and remove fails_silently#1295
Conversation
68c035f to
b6a3221
Compare
glevco
approved these changes
Jun 6, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1295 +/- ##
==========================================
+ Coverage 82.81% 82.86% +0.05%
==========================================
Files 362 362
Lines 25819 25823 +4
Branches 3952 3954 +2
==========================================
+ Hits 21382 21399 +17
+ Misses 3706 3697 -9
+ Partials 731 727 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Jun 6, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR prepares for enforcing different rules depending on how the vertex was received.
Acceptance Criteria
VertexHandler.on_new_block()which adds a new block and its dependencies.VertexHandler.on_new_mempool_transaction()which adds a new transaction in the mempool.VertexHandler.on_new_relayed_vertex()which adds an unsolicited vertex.VertexHandler.on_new_vertex()and the choice to fail silently.fails_silentlyargument fromHathorManager.on_new_tx().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged