test(nano): add tests (batch 2) [part 16]#1293
Merged
Conversation
glevco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
+ Coverage 84.03% 85.23% +1.20%
==========================================
Files 426 426
Lines 31908 31908
Branches 4950 4950
==========================================
+ Hits 26813 27197 +384
+ Misses 4066 3684 -382
+ Partials 1029 1027 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
tests/nano/batch1
branch
3 times, most recently
from
43d6f40 to
bdcc79b
Compare
glevco
force-pushed
the
tests/nano/batch2
branch
2 times, most recently
from
4283aba to
75e0300
Compare
glevco
force-pushed
the
tests/nano/batch1
branch
from
bdcc79b to
0ed4ecf
Compare
glevco
force-pushed
the
tests/nano/batch2
branch
from
75e0300 to
4df2728
Compare
glevco
force-pushed
the
tests/nano/batch1
branch
from
0ed4ecf to
c7dad1d
Compare
glevco
force-pushed
the
tests/nano/batch2
branch
from
4df2728 to
088e1f6
Compare
glevco
force-pushed
the
tests/nano/batch1
branch
2 times, most recently
from
bd2d580 to
8fedc74
Compare
glevco
force-pushed
the
tests/nano/batch2
branch
from
088e1f6 to
5c5665f
Compare
glevco
force-pushed
the
tests/nano/batch1
branch
from
8fedc74 to
1b3a848
Compare
glevco
force-pushed
the
tests/nano/batch2
branch
from
5c5665f to
b2bf246
Compare
glevco
force-pushed
the
tests/nano/batch1
branch
from
7dc5f1a to
4fb6bb6
Compare
glevco
force-pushed
the
tests/nano/batch2
branch
3 times, most recently
from
c76d116 to
5e54f1d
Compare
Contributor
Author
|
LGTM ✅ |
jansegre
previously approved these changes
Jun 25, 2025
| from tests.nanocontracts.blueprints.unittest import BlueprintTestCase | ||
| from tests.nanocontracts.utils import assert_nc_failure_reason | ||
|
|
||
| # TODO: Test support for container args/kwargs such as list[int] after Jan's PR |
Member
There was a problem hiding this comment.
Container args are fully supported, this TODO can be implemented.
Contributor
Author
There was a problem hiding this comment.
There's an existing task in the spreadsheet for this.
Comment on lines
+209
to
+211
| for tx in nc_others: | ||
| # TODO Assert the execution order. | ||
| assert tx.get_metadata().voided_by is None |
Member
There was a problem hiding this comment.
This seems like an important TODO for a sorter test.
glevco
force-pushed
the
tests/nano/batch2
branch
from
5e54f1d to
9b71b40
Compare
|
Bencher Report| Branch | tests/nano/batch2 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.71 m(+4.40%)Baseline: 1.63 m | 1.47 m (86.21%) | 1.80 m (94.91%) |
jansegre
approved these changes
Jun 26, 2025
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Proceed with merging Nano on master.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged