tests(nano): add basic structures and resources tests [part 14]#1291
Merged
tests(nano): add basic structures and resources tests [part 14]#1291
Conversation
glevco
force-pushed
the
tests/nano/resources
branch
2 times, most recently
from
e3f9298 to
9c202ba
Compare
glevco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (81.80%) is below the target coverage (82.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
+ Coverage 77.97% 81.80% +3.83%
==========================================
Files 426 426
Lines 31904 31908 +4
Branches 4950 4950
==========================================
+ Hits 24877 26103 +1226
+ Misses 6074 4752 -1322
- Partials 953 1053 +100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
feat/nano/consensus
branch
2 times, most recently
from
0b6f616 to
d5fb072
Compare
glevco
force-pushed
the
tests/nano/resources
branch
2 times, most recently
from
dc5c03f to
43f2ee1
Compare
glevco
force-pushed
the
feat/nano/consensus
branch
7 times, most recently
from
d394b7b to
6b09bf8
Compare
glevco
force-pushed
the
feat/nano/consensus
branch
from
6b09bf8 to
13588c1
Compare
glevco
force-pushed
the
tests/nano/resources
branch
2 times, most recently
from
83a5aaa to
65f1efc
Compare
glevco
commented
Jun 23, 2025
| """Create a HathorManager instance.""" | ||
| return self.create_peer('testnet', nc_indices=True, nc_log_config=NCLogConfig.FAILED, wallet_index=True) | ||
|
|
||
| def register_blueprint_class(self, blueprint_id: BlueprintId, blueprint_class: type[Blueprint]) -> None: |
Contributor
Author
There was a problem hiding this comment.
Instead of receiving a mandatory blueprint_id, we could generate one, use it, and return it. Most tests won't need to pass this argument.
| def build_runner(self) -> TestRunner: | ||
| """Create a Runner instance.""" | ||
| nc_storage_factory = NCMemoryStorageFactory() | ||
| store = MemoryNodeTrieStore() |
glevco
force-pushed
the
tests/nano/resources
branch
from
65f1efc to
bf557d8
Compare
|
Bencher Report| Branch | tests/nano/resources |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.65 m(+0.63%)Baseline: 1.63 m | 1.47 m (89.43%) | 1.80 m (91.49%) |
glevco
force-pushed
the
tests/nano/resources
branch
2 times, most recently
from
a17bc17 to
35bd094
Compare
Contributor
Author
|
LGTM ✅ |
jansegre
previously approved these changes
Jun 24, 2025
glevco
force-pushed
the
tests/nano/resources
branch
from
35bd094 to
60366fd
Compare
jansegre
approved these changes
Jun 24, 2025
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Proceed with the nano merge on master.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged