feat(nano): implement resources and events [part 12]#1289
Conversation
2377942 to
dddde16
Compare
dddde16 to
e502727
Compare
e502727 to
010c4b9
Compare
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (75.68%) is below the target coverage (82.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 76.42% 75.68% -0.74%
==========================================
Files 417 426 +9
Lines 30724 31455 +731
Branches 4798 4873 +75
==========================================
+ Hits 23480 23808 +328
- Misses 6429 6835 +406
+ Partials 815 812 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b218b30 to
fa7540e
Compare
0880346 to
758f0c5
Compare
ae60bb0 to
fd019e7
Compare
758f0c5 to
fb7fa8f
Compare
fb7fa8f to
fdfe8f2
Compare
fdfe8f2 to
18d0a50
Compare
|
| Branch | feat/nano/resources-and-events |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.59 m(-2.26%)Baseline: 1.63 m | 1.47 m (92.08%) | 1.79 m (88.85%) |
| if not (is_nc_public_method(method) or is_nc_view_method(method)): | ||
| continue |
There was a problem hiding this comment.
Should we add some info about the fallback method? At least a flag stating whether it's available.
| ) | ||
| return response.json_dumpb() | ||
|
|
||
| def _get_nc_creation_item(self, nc_id: bytes) -> NCCreationItem | None: |
There was a problem hiding this comment.
FIX: I think there's a bug when searching for a contract created by another contract, because this method assumes the nc_id is a tx.
There was a problem hiding this comment.
I'm changing this to a postponed thread. It's not critical because it only affects the search feature on the nc_creation explorer API.
Initially I thought it would be a simple fix on the resource itself, but that's not the case. The NC creation index only stores the tx's hash and timestamp, therefore it's not possible to use it to retrieve a tx via a contract id when that contract was created by another contract.
The fix is more involved and relates to other improvements in all explorer APIs. Those should be addressed in future PRs. A partial implementation (well, just a test) was started in fix/nano/nc_creation_by_another.
18d0a50 to
4790263
Compare
Co-authored-by: Marcelo Salhab Brogliato <msbrogli@gmail.com> Co-authored-by: Jan Segre <jan@hathor.network>
4790263 to
16253fa
Compare
|
LGTM ✅ |
Motivation
Continue with the nano merges, adding all resources and event handling.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged