Conversation
glevco
changed the title
glevco
force-pushed
the
feat/nano/metadata
branch
from
e583324 to
4a6ac38
Compare
glevco
force-pushed
the
feat/nano/runner
branch
2 times, most recently
from
a1992c9 to
1d16e19
Compare
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (76.49%) is below the target coverage (82.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 77.40% 76.49% -0.92%
==========================================
Files 415 417 +2
Lines 30127 30724 +597
Branches 4686 4798 +112
==========================================
+ Hits 23321 23503 +182
- Misses 5994 6414 +420
+ Partials 812 807 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
feat/nano/metadata
branch
2 times, most recently
from
08811ee to
5fffa3a
Compare
glevco
force-pushed
the
feat/nano/runner
branch
2 times, most recently
from
b218b30 to
fa7540e
Compare
glevco
force-pushed
the
feat/nano/metadata
branch
2 times, most recently
from
2e560a5 to
ed4b8db
Compare
glevco
commented
Jun 16, 2025
Comment on lines
+56
to
+61
| try: | ||
| obj = instance.syscall.__storage__.get_obj(self.__storage_key(), self.__nc_type) | ||
| instance.syscall.__cache__[self.__name] = obj | ||
| return obj | ||
| except KeyError: | ||
| raise AttributeError(f'Contract has no attribute \'{self.__name}\'') |
Contributor
Author
There was a problem hiding this comment.
Move the cache set to outside the try
glevco
commented
Jun 16, 2025
|
Bencher Report| Branch | feat/nano/runner |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.65 m(+1.33%)Baseline: 1.63 m | 1.47 m (88.82%) | 1.79 m (92.12%) |
jansegre
previously approved these changes
Jun 17, 2025
jansegre
approved these changes
Jun 17, 2025
Contributor
Author
|
LGTM ✅ |
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Continue with the nano merges, adding the
Runnerand related structures.Acceptance Criteria
Runner.Blueprintwith now available methods.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged