feat(nano): implement new metadata [part 10]#1287
Merged
Conversation
24f3c51 to
e583324
Compare
e583324 to
4a6ac38
Compare
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (77.41%) is below the target coverage (82.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
- Coverage 77.85% 77.41% -0.44%
==========================================
Files 415 415
Lines 29918 30127 +209
Branches 4636 4686 +50
==========================================
+ Hits 23293 23324 +31
- Misses 5820 5992 +172
- Partials 805 811 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2dee266 to
9d34a6f
Compare
08811ee to
5fffa3a
Compare
glevco
commented
Jun 11, 2025
1d348bf to
71795da
Compare
jansegre
previously approved these changes
Jun 16, 2025
5fffa3a to
9606915
Compare
|
| Branch | feat/nano/metadata |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.63 m(-0.16%)Baseline: 1.63 m | 1.47 m (90.14%) | 1.79 m (90.77%) |
Contributor
Author
|
LGTM ✅ |
jansegre
approved these changes
Jun 16, 2025
2e560a5 to
ed4b8db
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Continue with the nano merges, adding new metadata and some other smaller changes.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged