Skip to content

feat(nano): implement new metadata [part 10]#1287

Merged
jansegre merged 1 commit intomasterfrom
feat/nano/metadata
Jun 16, 2025
Merged

feat(nano): implement new metadata [part 10]#1287
jansegre merged 1 commit intomasterfrom
feat/nano/metadata

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 3, 2025

Motivation

Continue with the nano merges, adding new metadata and some other smaller changes.

Acceptance Criteria

  • Add new nano metadata.
  • Change TokenInfo from a NamedTuple to a mutable dataclass.
  • Update indexes to consider nano logic.
  • Add missing balance rules and some other smaller changes.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jun 3, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners June 3, 2025 21:16
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Jun 3, 2025
@glevco glevco changed the title feat(nano): implement new metadata feat(nano): implement new metadata [part 10] Jun 3, 2025
@glevco glevco force-pushed the feat/nano/metadata branch from 24f3c51 to e583324 Compare June 3, 2025 21:22
@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jun 3, 2025
@glevco glevco force-pushed the feat/nano/headers branch from 781705e to 36e5fea Compare June 3, 2025 22:30
@glevco glevco force-pushed the feat/nano/metadata branch from e583324 to 4a6ac38 Compare June 3, 2025 22:30
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 29.43548% with 175 lines in your changes missing coverage. Please review.

Project coverage is 77.41%. Comparing base (71795da) to head (ed4b8db).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
hathor/indexes/manager.py 12.50% 69 Missing and 1 partial ⚠️
hathor/transaction/headers/nano_header.py 0.00% 33 Missing ⚠️
hathor/indexes/rocksdb_tokens_index.py 25.64% 27 Missing and 2 partials ⚠️
hathor/nanocontracts/balance_rules.py 0.00% 17 Missing ⚠️
hathor/transaction/transaction.py 76.47% 7 Missing and 1 partial ⚠️
hathor/nanocontracts/on_chain_blueprint.py 0.00% 6 Missing ⚠️
hathor/nanocontracts/storage/factory.py 0.00% 6 Missing ⚠️
hathor/transaction/transaction_metadata.py 73.91% 3 Missing and 3 partials ⚠️

❌ Your project status has failed because the head coverage (77.41%) is below the target coverage (82.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   77.85%   77.41%   -0.44%     
==========================================
  Files         415      415              
  Lines       29918    30127     +209     
  Branches     4636     4686      +50     
==========================================
+ Hits        23293    23324      +31     
- Misses       5820     5992     +172     
- Partials      805      811       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco force-pushed the feat/nano/headers branch 2 times, most recently from 2dee266 to 9d34a6f Compare June 11, 2025 19:57
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jun 11, 2025
@glevco glevco force-pushed the feat/nano/metadata branch 2 times, most recently from 08811ee to 5fffa3a Compare June 11, 2025 20:19
@glevco glevco force-pushed the feat/nano/headers branch 2 times, most recently from 1d348bf to 71795da Compare June 13, 2025 19:29
jansegre
jansegre previously approved these changes Jun 16, 2025
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Jun 16, 2025
@glevco glevco changed the base branch from feat/nano/headers to master June 16, 2025 18:38
@glevco glevco dismissed jansegre’s stale review June 16, 2025 18:38

The base branch was changed.

@glevco glevco force-pushed the feat/nano/metadata branch from 5fffa3a to 9606915 Compare June 16, 2025 18:47
@github-actions
Copy link

github-actions bot commented Jun 16, 2025

🐰 Bencher Report

Branchfeat/nano/metadata
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.63 m
(-0.16%)Baseline: 1.63 m
1.47 m
(90.14%)
1.79 m
(90.77%)
🐰 View full continuous benchmarking report in Bencher

@glevco
Copy link
Contributor Author

glevco commented Jun 16, 2025

LGTM ✅

@glevco glevco force-pushed the feat/nano/metadata branch from 2e560a5 to ed4b8db Compare June 16, 2025 19:02
@jansegre jansegre merged commit a249336 into master Jun 16, 2025
7 of 8 checks passed
@jansegre jansegre deleted the feat/nano/metadata branch June 16, 2025 19:58
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jun 16, 2025
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants