Skip to content

feat(nano): add indexes and more [part 7]#1284

Merged
jansegre merged 1 commit intomasterfrom
feat/nano/indexes
Jun 13, 2025
Merged

feat(nano): add indexes and more [part 7]#1284
jansegre merged 1 commit intomasterfrom
feat/nano/indexes

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 3, 2025

Motivation

Merge nano indexes and some other structures.

Acceptance Criteria

  • Add nano indexes.
  • Update NC types.
  • Add seqnum.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jun 3, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners June 3, 2025 16:13
@glevco glevco changed the title feat(nano): add indexes and more feat(nano): add indexes and more [part 7] Jun 3, 2025
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Jun 3, 2025
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 57.74648% with 210 lines in your changes missing coverage. Please review.

Project coverage is 78.92%. Comparing base (fac0881) to head (cb8cc56).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hathor/indexes/rocksdb_vertex_timestamp_index.py 44.44% 45 Missing ⚠️
hathor/indexes/rocksdb_tx_group_index.py 49.23% 29 Missing and 4 partials ⚠️
hathor/nanocontracts/nc_types/token_uid_nc_type.py 53.70% 24 Missing and 1 partial ⚠️
...nanocontracts/nc_types/fixed_size_bytes_nc_type.py 62.50% 18 Missing ⚠️
hathor/nanocontracts/storage/block_storage.py 37.50% 15 Missing ⚠️
hathor/indexes/blueprint_history_index.py 59.37% 13 Missing ⚠️
hathor/indexes/nc_history_index.py 67.56% 12 Missing ⚠️
hathor/wallet/keypair.py 10.00% 9 Missing ⚠️
hathor/indexes/vertex_timestamp_index.py 78.37% 8 Missing ⚠️
hathor/indexes/nc_creation_index.py 60.00% 6 Missing ⚠️
... and 7 more

❌ Your project status has failed because the head coverage (78.92%) is below the target coverage (82.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
- Coverage   79.18%   78.92%   -0.27%     
==========================================
  Files         402      412      +10     
  Lines       28703    29171     +468     
  Branches     4404     4500      +96     
==========================================
+ Hits        22729    23023     +294     
- Misses       5205     5385     +180     
+ Partials      769      763       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco force-pushed the feat/nano/fundamentals-2 branch from b7c9ee3 to 70aed3e Compare June 3, 2025 18:44
@glevco glevco force-pushed the feat/nano/indexes branch from 1ed319c to e6c3a52 Compare June 3, 2025 18:45
@glevco glevco force-pushed the feat/nano/fundamentals-2 branch from 70aed3e to 46d98e8 Compare June 3, 2025 19:58
@glevco glevco force-pushed the feat/nano/indexes branch from e6c3a52 to a13b182 Compare June 3, 2025 20:00
@glevco glevco force-pushed the feat/nano/fundamentals-2 branch 6 times, most recently from f7b24f4 to 06cab98 Compare June 11, 2025 14:41
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jun 11, 2025
@glevco glevco force-pushed the feat/nano/indexes branch 2 times, most recently from eefcf44 to 9e759b4 Compare June 11, 2025 18:46
@glevco
Copy link
Contributor Author

glevco commented Jun 11, 2025

LGTM ✅

@glevco glevco force-pushed the feat/nano/fundamentals-2 branch from 06cab98 to c15f4a0 Compare June 11, 2025 21:54
@glevco glevco changed the base branch from feat/nano/fundamentals-2 to master June 11, 2025 21:58
@glevco glevco force-pushed the feat/nano/indexes branch from 9e759b4 to cb8cc56 Compare June 13, 2025 13:47
@github-actions
Copy link

🐰 Bencher Report

Branchfeat/nano/indexes
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.58 m
(-2.73%)Baseline: 1.63 m
1.47 m
(92.53%)
1.79 m
(88.43%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre merged commit 47c3dd1 into master Jun 13, 2025
7 of 8 checks passed
@jansegre jansegre deleted the feat/nano/indexes branch June 13, 2025 14:57
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Jun 13, 2025
@glevco glevco restored the feat/nano/indexes branch June 13, 2025 14:59
@glevco glevco deleted the feat/nano/indexes branch June 13, 2025 15:02
@glevco glevco restored the feat/nano/indexes branch June 13, 2025 15:02
@jansegre jansegre deleted the feat/nano/indexes branch June 13, 2025 15:07
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants