Skip to content

feat(nano): implement fundamental nano structures [part 2]#1277

Merged
glevco merged 1 commit intomasterfrom
feat/nano/fundamental
Jun 3, 2025
Merged

feat(nano): implement fundamental nano structures [part 2]#1277
glevco merged 1 commit intomasterfrom
feat/nano/fundamental

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 30, 2025

Motivation

Implement some fundamental nano types and structures.

No code is changed from the original implementation, but some code had to be removed to limit dependencies. Code is either completely removed or replaced with NotImplementedError('temporarily removed during nano merge'). For instance, no code is commented. This will make it easier to resolve conflicts in the nano repo. I'll use this approach in the following PRs, an they'll refill the NotImplementedError when it's possible.

Acceptance Criteria

  • Implement some fundamental nano types and structures.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this May 30, 2025
@glevco glevco requested review from jansegre and msbrogli as code owners May 30, 2025 16:50
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network May 30, 2025
@glevco glevco changed the title feat(nano): implement fundamental nano structures feat(nano): implement fundamental nano structures [part 2] May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 65.02547% with 206 lines in your changes missing coverage. Please review.

Project coverage is 83.64%. Comparing base (58a7796) to head (e04eefd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/transaction/headers/nano_header.py 27.70% 107 Missing ⚠️
...athor/nanocontracts/blueprint_syntax_validation.py 22.85% 27 Missing ⚠️
hathor/nanocontracts/types.py 80.37% 20 Missing and 1 partial ⚠️
hathor/nanocontracts/context.py 60.86% 18 Missing ⚠️
hathor/nanocontracts/vertex_data.py 78.46% 14 Missing ⚠️
hathor/utils/leb128.py 67.44% 12 Missing and 2 partials ⚠️
hathor/utils/typing.py 90.74% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
- Coverage   84.05%   83.64%   -0.42%     
==========================================
  Files         334      346      +12     
  Lines       24340    24929     +589     
  Branches     3603     3692      +89     
==========================================
+ Hits        20460    20852     +392     
- Misses       3156     3346     +190     
- Partials      724      731       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jansegre
jansegre previously approved these changes Jun 2, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jun 2, 2025
msbrogli
msbrogli previously approved these changes Jun 2, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jun 2, 2025
@glevco glevco force-pushed the feat/nano/serialization branch 2 times, most recently from ad90b1a to a9183a2 Compare June 2, 2025 18:50
Base automatically changed from feat/nano/serialization to master June 2, 2025 19:18
@glevco glevco dismissed stale reviews from msbrogli and jansegre June 2, 2025 19:18

The base branch was changed.

@glevco glevco force-pushed the feat/nano/fundamental branch from a9db88b to 1189092 Compare June 2, 2025 19:18
@glevco glevco force-pushed the feat/nano/fundamental branch from 1189092 to e04eefd Compare June 2, 2025 19:19
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

🐰 Bencher Report

Branchfeat/nano/fundamental
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.60 m
(-1.78%)Baseline: 1.63 m
1.47 m
(91.63%)
1.79 m
(89.29%)
🐰 View full continuous benchmarking report in Bencher

@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Jun 2, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jun 3, 2025
@glevco glevco merged commit edc4f98 into master Jun 3, 2025
8 checks passed
@glevco glevco deleted the feat/nano/fundamental branch June 3, 2025 02:23
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jun 3, 2025
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants