feat(nano): implement fundamental nano structures [part 2]#1277
Merged
feat(nano): implement fundamental nano structures [part 2]#1277
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
- Coverage 84.05% 83.64% -0.42%
==========================================
Files 334 346 +12
Lines 24340 24929 +589
Branches 3603 3692 +89
==========================================
+ Hits 20460 20852 +392
- Misses 3156 3346 +190
- Partials 724 731 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
previously approved these changes
Jun 2, 2025
msbrogli
reviewed
Jun 2, 2025
msbrogli
reviewed
Jun 2, 2025
msbrogli
previously approved these changes
Jun 2, 2025
ad90b1a to
a9183a2
Compare
The base branch was changed.
a9db88b to
1189092
Compare
1189092 to
e04eefd
Compare
|
| Branch | feat/nano/fundamental |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.60 m(-1.78%)Baseline: 1.63 m | 1.47 m (91.63%) | 1.79 m (89.29%) |
jansegre
approved these changes
Jun 2, 2025
msbrogli
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement some fundamental nano types and structures.
No code is changed from the original implementation, but some code had to be removed to limit dependencies. Code is either completely removed or replaced with
NotImplementedError('temporarily removed during nano merge'). For instance, no code is commented. This will make it easier to resolve conflicts in the nano repo. I'll use this approach in the following PRs, an they'll refill theNotImplementedErrorwhen it's possible.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged