Skip to content

feat(nano): implement serialization module [part 1]#1276

Merged
glevco merged 1 commit intomasterfrom
feat/nano/serialization
Jun 2, 2025
Merged

feat(nano): implement serialization module [part 1]#1276
glevco merged 1 commit intomasterfrom
feat/nano/serialization

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 30, 2025

Motivation

Implement the hathor/serialization module.

Acceptance Criteria

  • Implement the hathor/serialization module.
  • Signed data support is left out.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this May 30, 2025
@glevco glevco requested a review from jansegre as a code owner May 30, 2025 15:59
@glevco glevco requested a review from msbrogli as a code owner May 30, 2025 15:59
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network May 30, 2025
@github-actions
Copy link

github-actions bot commented May 30, 2025

🐰 Bencher Report

Branchfeat/nano/serialization
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.63 m
(-0.39%)Baseline: 1.63 m
1.47 m
(90.35%)
1.80 m
(90.55%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the feat/nano/serialization branch from ca798c4 to 42c16a1 Compare May 30, 2025 16:16
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 81.10403% with 89 lines in your changes missing coverage. Please review.

Project coverage is 84.05%. Comparing base (5927188) to head (a9183a2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/serialization/adapters/max_bytes.py 54.00% 23 Missing ⚠️
hathor/serialization/deserializer.py 68.42% 18 Missing ⚠️
hathor/serialization/adapters/generic_adapter.py 70.17% 17 Missing ⚠️
hathor/serialization/serializer.py 68.42% 12 Missing ⚠️
hathor/serialization/bytes_deserializer.py 82.22% 4 Missing and 4 partials ⚠️
hathor/serialization/encoding/output_value.py 87.50% 3 Missing and 1 partial ⚠️
hathor/serialization/compound_encoding/__init__.py 83.33% 2 Missing ⚠️
hathor/serialization/encoding/int.py 81.81% 2 Missing ⚠️
hathor/serialization/encoding/leb128.py 92.59% 1 Missing and 1 partial ⚠️
hathor/serialization/bytes_serializer.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
- Coverage   84.10%   84.05%   -0.05%     
==========================================
  Files         311      334      +23     
  Lines       23869    24340     +471     
  Branches     3525     3603      +78     
==========================================
+ Hits        20075    20459     +384     
- Misses       3074     3157      +83     
- Partials      720      724       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco changed the title feat(nano): implement serialization module feat(nano): implement serialization module [part 1] May 30, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jun 2, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jun 2, 2025
@glevco glevco force-pushed the feat/nano/serialization branch from 42c16a1 to ad90b1a Compare June 2, 2025 17:26
@glevco glevco force-pushed the feat/nano/serialization branch from ad90b1a to a9183a2 Compare June 2, 2025 18:50
@glevco glevco merged commit 58a7796 into master Jun 2, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jun 2, 2025
@glevco glevco deleted the feat/nano/serialization branch June 2, 2025 19:18
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants