Merged
Conversation
|
Bencher Report| Branch | chore/make-fix-rocksdb |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.70 m(+4.14%)Baseline: 1.63 m | 1.47 m (86.42%) | 1.80 m (94.67%) |
msbrogli
approved these changes
Apr 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
+ Coverage 84.08% 84.10% +0.01%
==========================================
Files 311 311
Lines 23869 23869
Branches 3651 3651
==========================================
+ Hits 20070 20074 +4
+ Misses 3080 3076 -4
Partials 719 719 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Apr 2, 2025
glevco
force-pushed
the
chore/make-fix-rocksdb
branch
from
bd08c17 to
919fdab
Compare
glevco
force-pushed
the
chore/make-fix-rocksdb
branch
from
919fdab to
d95cd64
Compare
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes when rocksdb is upgraded, the
python-rocksdbbindings installation stops working, and a simple reinstall with--no-binaryfixes it. This PR adds this command to the Makefile so it's easier for new devs to deal with this.PS: Poetry does support the no-binary option as a local config, but I couldn't get it to work. It seems it doesn't work with dependencies from git.
Acceptance Criteria
make fix-rocksdbcommand.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged