Skip to content

chore: add reorg log#1253

Merged
jansegre merged 1 commit intomasterfrom
chore/log-reorg
Oct 21, 2025
Merged

chore: add reorg log#1253
jansegre merged 1 commit intomasterfrom
chore/log-reorg

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Apr 1, 2025

Motivation

It would be useful to track reorgs via full node logs.

Acceptance Criteria

  • Add an info log whenever a reorg happens.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Apr 1, 2025
@glevco glevco requested a review from jansegre as a code owner April 1, 2025 16:38
@glevco glevco requested a review from msbrogli as a code owner April 1, 2025 16:38
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Apr 1, 2025
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

🐰 Bencher Report

Branchchore/log-reorg
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.70 m
(-1.61%)Baseline: 1.73 m
1.56 m
(91.47%)
2.08 m
(82.00%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Apr 1, 2025
jansegre
jansegre previously approved these changes Apr 1, 2025
msbrogli
msbrogli previously approved these changes Apr 1, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.11%. Comparing base (e5809e9) to head (4802e53).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1253      +/-   ##
==========================================
- Coverage   86.12%   86.11%   -0.02%     
==========================================
  Files         437      437              
  Lines       34078    34079       +1     
  Branches     5328     5328              
==========================================
- Hits        29350    29347       -3     
  Misses       3683     3683              
- Partials     1045     1049       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Apr 1, 2025
@glevco glevco force-pushed the chore/log-reorg branch from 3a1b660 to 449f104 Compare April 3, 2025 16:35
@glevco glevco moved this from In Review (Done) to In Review (WIP) in Hathor Network Apr 4, 2025
@glevco glevco dismissed stale reviews from msbrogli and jansegre via ec80c24 October 15, 2025 21:00
@glevco glevco force-pushed the chore/log-reorg branch 2 times, most recently from ec80c24 to f0a1f89 Compare October 15, 2025 21:02
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 20, 2025
@glevco glevco force-pushed the chore/log-reorg branch 3 times, most recently from 4802e53 to cb4bdd0 Compare October 21, 2025 14:06
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Oct 21, 2025
# Conflicts:
#	hathor/consensus/consensus.py
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 21, 2025
@jansegre jansegre mentioned this pull request Oct 21, 2025
2 tasks
@jansegre jansegre merged commit 607e0a3 into master Oct 21, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Oct 21, 2025
@jansegre jansegre deleted the chore/log-reorg branch October 21, 2025 14:18
@jansegre jansegre mentioned this pull request Oct 21, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants