feat(events): change empty decoded from None to empty dict#1250
Merged
feat(events): change empty decoded from None to empty dict#1250
Conversation
|
Bencher Report| Branch | feat/events/empty-decoded |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.63 m(+0.01%)Baseline: 1.63 m | 1.47 m (89.99%) | 1.80 m (90.92%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1250 +/- ##
==========================================
- Coverage 84.11% 84.09% -0.02%
==========================================
Files 311 311
Lines 23868 23864 -4
Branches 3651 3649 -2
==========================================
- Hits 20076 20068 -8
- Misses 3074 3075 +1
- Partials 718 721 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedroferreira1
approved these changes
Mar 27, 2025
msbrogli
approved these changes
Mar 31, 2025
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our wallet-service use case requested that empty decoded outputs in events should be represented as
{}instead ofNone.Acceptance Criteria
Noneto{}.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged