Merged
Conversation
ec1ac1a to
3d9c2ae
Compare
|
| Branch | feat/add-gc-metrics |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.72 m(-0.74%)Baseline: 1.73 m | 1.56 m (90.67%) | 2.08 m (82.71%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
+ Coverage 86.06% 86.11% +0.04%
==========================================
Files 437 437
Lines 33967 33972 +5
Branches 5316 5316
==========================================
+ Hits 29235 29256 +21
+ Misses 3684 3675 -9
+ Partials 1048 1041 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
commented
Mar 19, 2025
luislhl
reviewed
Mar 20, 2025
luislhl
reviewed
Mar 20, 2025
6e8dfe3 to
4e142bd
Compare
luislhl
approved these changes
Oct 28, 2025
review changes
4e142bd to
96c52a6
Compare
jansegre
approved these changes
Nov 3, 2025
This was referenced Dec 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Prometheus garbage collector
objectsmetric does not currently reflect the tracked objects count, but a different count according to the docs:This PR adds the
tracked_objectsmetric that gets the correct value, and keeps theobjectsmetric with an updated description. Also, for reference.Acceptance Criteria
HathorSettings.PROMETHEUS_WRITE_INTERVALfrom 5 seconds to 15 seconds, as our Prometheus server only scraps the full node every 30s, so we're making too many unnecessary updates.tracked_objectsgarbage collector metric.objectsgarbage collector metric description and rename it tocollection_counts.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged