Skip to content

feat: add --temp-data CLI option#1228

Merged
msbrogli merged 1 commit intomasterfrom
feat/add-temp-data
Mar 7, 2025
Merged

feat: add --temp-data CLI option#1228
msbrogli merged 1 commit intomasterfrom
feat/add-temp-data

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Feb 25, 2025

Motivation

In preparation for removing memory storage and indexes, this PR adds the --temp-data CLI option to substitute --memory-storage

Acceptance Criteria

  • Implement --temp-data.
  • Deprecate --memory-storage and --memory-indexes.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Feb 25, 2025
@glevco glevco force-pushed the feat/add-temp-data branch 2 times, most recently from 7f3657c to 4be3517 Compare February 25, 2025 16:34
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Feb 25, 2025
@glevco glevco marked this pull request as ready for review February 25, 2025 16:34
@github-actions
Copy link

github-actions bot commented Feb 25, 2025

🐰 Bencher Report

Branchfeat/add-temp-data
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.49 m
(-8.20%)Baseline: 1.62 m
1.46 m
(98.04%)
1.79 m
(83.46%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the feat/add-temp-data branch from 4be3517 to 0c6d948 Compare February 25, 2025 16:42
jansegre
jansegre previously approved these changes Feb 25, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Feb 25, 2025
@glevco glevco force-pushed the feat/add-temp-data branch from 0c6d948 to 3946b13 Compare February 25, 2025 17:13
jansegre
jansegre previously approved these changes Feb 25, 2025
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (dbcff55) to head (6f5c3ad).

Files with missing lines Patch % Lines
hathor/storage/rocksdb_storage.py 72.72% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   84.26%   84.28%   +0.01%     
==========================================
  Files         320      320              
  Lines       24455    24471      +16     
  Branches     3744     3748       +4     
==========================================
+ Hits        20608    20626      +18     
- Misses       3113     3115       +2     
+ Partials      734      730       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 6, 2025
@msbrogli msbrogli force-pushed the feat/add-temp-data branch from 6f5c3ad to 6f3124a Compare March 7, 2025 17:03
@msbrogli msbrogli merged commit 6f3124a into master Mar 7, 2025
@msbrogli msbrogli deleted the feat/add-temp-data branch March 7, 2025 17:04
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Mar 7, 2025
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants