Conversation
7f3657c to
4be3517
Compare
|
| Branch | feat/add-temp-data |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.49 m(-8.20%)Baseline: 1.62 m | 1.46 m (98.04%) | 1.79 m (83.46%) |
4be3517 to
0c6d948
Compare
jansegre
previously approved these changes
Feb 25, 2025
0c6d948 to
3946b13
Compare
jansegre
previously approved these changes
Feb 25, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
+ Coverage 84.26% 84.28% +0.01%
==========================================
Files 320 320
Lines 24455 24471 +16
Branches 3744 3748 +4
==========================================
+ Hits 20608 20626 +18
- Misses 3113 3115 +2
+ Partials 734 730 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
requested changes
Mar 5, 2025
msbrogli
approved these changes
Mar 7, 2025
6f5c3ad to
6f3124a
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In preparation for removing memory storage and indexes, this PR adds the
--temp-dataCLI option to substitute--memory-storageAcceptance Criteria
--temp-data.--memory-storageand--memory-indexes.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged