Skip to content

feat(dag-builder): improve DAGBuilder#1225

Merged
glevco merged 1 commit intomasterfrom
feat/improve-dag-builder
Feb 15, 2025
Merged

feat(dag-builder): improve DAGBuilder#1225
glevco merged 1 commit intomasterfrom
feat/improve-dag-builder

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Feb 14, 2025

Motivation

This PR cherry-picks some DAGBuilder improvements from our private repo.

Acceptance Criteria

  • Introduce DAGArtifacts.get_typed_vertex, get_typed_vertices, propagate_with convenience methods.
  • Add node name to vertex objects, to aid debugging.
  • Improve syntax docs.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Feb 14, 2025
@glevco glevco marked this pull request as ready for review February 14, 2025 23:31
@github-actions
Copy link

🐰 Bencher Report

Branchfeat/improve-dag-builder
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.54
(-5.69%)Baseline: 1.63
1.47
(95.43%)
1.80
(85.74%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (91e2bd8) to head (85d88dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
- Coverage   84.47%   84.38%   -0.09%     
==========================================
  Files         320      320              
  Lines       24559    24584      +25     
  Branches     3762     3767       +5     
==========================================
- Hits        20747    20746       -1     
- Misses       3077     3093      +16     
- Partials      735      745      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit 4513ddf into master Feb 15, 2025
10 checks passed
@glevco glevco deleted the feat/improve-dag-builder branch February 15, 2025 00:54
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants