Skip to content

feat(vertex_handler): Improve new vertex log#1224

Merged
msbrogli merged 1 commit intomasterfrom
feat/improve-new-vertex-log
Apr 2, 2025
Merged

feat(vertex_handler): Improve new vertex log#1224
msbrogli merged 1 commit intomasterfrom
feat/improve-new-vertex-log

Conversation

@msbrogli
Copy link
Member

@msbrogli msbrogli commented Feb 14, 2025

Motivation

As a node operator, having access to detailed log information is crucial for understanding the behavior of the system. Currently, log entries for block and tx events do not specify whether those blocks or transactions are valid or have been voided. This lack of clarity can create confusion—one might see multiple block log entries and incorrectly assume that mining is proceeding normally, when in fact those blocks could be voided.

Acceptance Criteria

  1. Update the log messages so they explicitly differentiate between voided and non-voided vertices.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner February 14, 2025 19:10
@msbrogli msbrogli self-assigned this Feb 14, 2025
@github-actions
Copy link

github-actions bot commented Feb 14, 2025

🐰 Bencher Report

Branchfeat/improve-new-vertex-log
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.62 m
(-0.97%)Baseline: 1.63 m
1.47 m
(90.88%)
1.80 m
(90.03%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (91e2bd8) to head (64fdaed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   84.47%   84.42%   -0.06%     
==========================================
  Files         320      320              
  Lines       24559    24563       +4     
  Branches     3762     3764       +2     
==========================================
- Hits        20747    20738       -9     
- Misses       3077     3085       +8     
- Partials      735      740       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msbrogli msbrogli moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Apr 2, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Apr 2, 2025
@msbrogli msbrogli force-pushed the feat/improve-new-vertex-log branch from 64fdaed to 70700f7 Compare April 2, 2025 16:24
@msbrogli msbrogli merged commit 70700f7 into master Apr 2, 2025
9 checks passed
@msbrogli msbrogli deleted the feat/improve-new-vertex-log branch April 2, 2025 16:25
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Apr 2, 2025
@msbrogli msbrogli moved this from Waiting to be deployed to Done in Hathor Network Apr 24, 2025
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants