feat(vertex_handler): Improve new vertex log#1224
Merged
Conversation
|
| Branch | feat/improve-new-vertex-log |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.62 m(-0.97%)Baseline: 1.63 m | 1.47 m (90.88%) | 1.80 m (90.03%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
- Coverage 84.47% 84.42% -0.06%
==========================================
Files 320 320
Lines 24559 24563 +4
Branches 3762 3764 +2
==========================================
- Hits 20747 20738 -9
- Misses 3077 3085 +8
- Partials 735 740 +5 ☔ View full report in Codecov by Sentry. |
glevco
approved these changes
Apr 2, 2025
jansegre
approved these changes
Apr 2, 2025
64fdaed to
70700f7
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As a node operator, having access to detailed log information is crucial for understanding the behavior of the system. Currently, log entries for block and tx events do not specify whether those blocks or transactions are valid or have been voided. This lack of clarity can create confusion—one might see multiple block log entries and incorrectly assume that mining is proceeding normally, when in fact those blocks could be voided.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged