chore: Improve HathorSettings imports#1223
Merged
Conversation
|
Bencher Report| Branch | chore/fix-settings-import |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.59(-2.65%)Baseline: 1.63 | 1.47 (92.45%) | 1.80 (88.50%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1223 +/- ##
==========================================
+ Coverage 84.38% 84.47% +0.08%
==========================================
Files 320 320
Lines 24565 24559 -6
Branches 3762 3762
==========================================
+ Hits 20730 20747 +17
+ Misses 3092 3077 -15
+ Partials 743 735 -8 ☔ View full report in Codecov by Sentry. |
msbrogli
force-pushed
the
chore/fix-settings-import
branch
from
9ac6181 to
91e2bd8
Compare
glevco
approved these changes
Feb 14, 2025
jansegre
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some files are still causing circular imports. This PR improve some imports to avoid it.
Acceptance Criteria
HathorSettingsto theTYPE_CHECKINGcondition.from __future__ import annotationsin some files.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged