Skip to content

fix(metrics): websocket metrics was not being updated#1221

Merged
jansegre merged 1 commit intomasterfrom
fix/websocket-metrics
Feb 13, 2025
Merged

fix(metrics): websocket metrics was not being updated#1221
jansegre merged 1 commit intomasterfrom
fix/websocket-metrics

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Feb 6, 2025

Motivation

Fixes #1204

Acceptance Criteria

  • When setting the websocket_factory on the CliBuilder also update the manager.metrics otherwise it will remain None and not be able to observe the stats

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from glevco and luislhl February 6, 2025 16:11
@jansegre jansegre self-assigned this Feb 6, 2025
@jansegre jansegre requested a review from msbrogli as a code owner February 6, 2025 16:11
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

🐰 Bencher Report

Branchfix/websocket-metrics
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.51
(-7.95%)Baseline: 1.64
1.47
(97.77%)
1.80
(83.68%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (22ab6a8) to head (2167098).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   84.43%   84.40%   -0.04%     
==========================================
  Files         320      320              
  Lines       24564    24565       +1     
  Branches     3762     3762              
==========================================
- Hits        20740    20733       -7     
- Misses       3084     3090       +6     
- Partials      740      742       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the fix/websocket-metrics branch from bb7ae34 to 2167098 Compare February 13, 2025 16:46
@jansegre jansegre merged commit 00b82d9 into master Feb 13, 2025
10 checks passed
@jansegre jansegre deleted the fix/websocket-metrics branch February 13, 2025 18:03
@jansegre jansegre mentioned this pull request Jul 22, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jul 22, 2025
@jansegre jansegre mentioned this pull request Aug 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Websocket Connections Metrics not updating

3 participants