fix(metrics): websocket metrics was not being updated#1221
Merged
Conversation
|
| Branch | fix/websocket-metrics |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.51(-7.95%)Baseline: 1.64 | 1.47 (97.77%) | 1.80 (83.68%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
- Coverage 84.43% 84.40% -0.04%
==========================================
Files 320 320
Lines 24564 24565 +1
Branches 3762 3762
==========================================
- Hits 20740 20733 -7
- Misses 3084 3090 +6
- Partials 740 742 +2 ☔ View full report in Codecov by Sentry. |
luislhl
approved these changes
Feb 6, 2025
glevco
approved these changes
Feb 13, 2025
bb7ae34 to
2167098
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1204
Acceptance Criteria
websocket_factoryon theCliBuilderalso update themanager.metricsotherwise it will remainNoneand not be able to observe the statsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged