Conversation
jansegre
previously approved these changes
Jan 31, 2025
|
Bencher Report| Branch | tests/reenable-tests |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.49 (-8.93%) | 1.47 (98.82%) | 1.80 (82.80%) |
glevco
force-pushed
the
tests/reenable-tests
branch
from
73535b7 to
e9a73fe
Compare
jansegre
previously approved these changes
Jan 31, 2025
glevco
force-pushed
the
tests/reenable-tests
branch
from
e9a73fe to
418ca3d
Compare
jansegre
previously approved these changes
Jan 31, 2025
glevco
force-pushed
the
tests/reenable-tests
branch
from
418ca3d to
60bfc2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
+ Coverage 83.65% 84.47% +0.81%
==========================================
Files 320 320
Lines 24562 24562
Branches 3767 3767
==========================================
+ Hits 20547 20748 +201
+ Misses 3256 3075 -181
+ Partials 759 739 -20 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Feb 3, 2025
msbrogli
approved these changes
Feb 3, 2025
This was referenced Feb 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We recently removed Sync-v1 from our tests suite, and I just found out that multiple tests are not running because they don't set
__test__ = Trueanymore.Acceptance Criteria
__test__ = Falsefrom theSimulatorTestCase.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged