fix(dag_builder): Fix generating two or more vertices with the same hash#1207
Merged
fix(dag_builder): Fix generating two or more vertices with the same hash#1207
Conversation
5a402a8 to
8b02ba5
Compare
jansegre
approved these changes
Jan 30, 2025
glevco
approved these changes
Jan 30, 2025
|
| Branch | fix/dag-builder-hash-conflict |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 1.48 (-10.41%) | 1.48 (100.46%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 1.48 (-10.41%) | 1.48 (100.46%) | 1.81 (81.44%) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 83.58% 83.65% +0.07%
==========================================
Files 320 320
Lines 24551 24562 +11
Branches 3764 3767 +3
==========================================
+ Hits 20520 20547 +27
+ Misses 3267 3256 -11
+ Partials 764 759 -5 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If might happen that two different transactions have the same hash if their description is exactly the same. This PR fixes it by increasing the nonce.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged