chore(p2p): decrease p2p.max_enabled_sync's default value: 16 -> 8#1199
Merged
chore(p2p): decrease p2p.max_enabled_sync's default value: 16 -> 8#1199
Conversation
|
Bencher Report| Branch | chore/reduce-max-enabled-sync |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.52 (-8.55%) | 1.49 (98.42%) | 1.82 (83.13%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
=======================================
Coverage 84.93% 84.94%
=======================================
Files 323 323
Lines 25124 25124
Branches 3859 3859
=======================================
+ Hits 21340 21342 +2
+ Misses 3041 3039 -2
Partials 743 743 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Jan 6, 2025
pedroferreira1
approved these changes
Jan 7, 2025
This was referenced Jan 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The default value of 16 can be slower than expected in certain cases.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged