chore(feature_activation): update start_height before release#1198
Merged
chore(feature_activation): update start_height before release#1198
Conversation
|
Bencher Report| Branch | chore/update-feature-activation-test |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.54 (-6.84%) | 1.49 (96.61%) | 1.82 (84.69%) |
msbrogli
previously approved these changes
Jan 6, 2025
jansegre
force-pushed
the
chore/update-feature-activation-test
branch
from
5ae35e6 to
d120c61
Compare
jansegre
force-pushed
the
chore/update-feature-activation-test
branch
from
d120c61 to
a538778
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
- Coverage 85.01% 84.88% -0.14%
==========================================
Files 323 323
Lines 25124 25124
Branches 3859 3859
==========================================
- Hits 21359 21326 -33
- Misses 3027 3050 +23
- Partials 738 748 +10 ☔ View full report in Codecov by Sentry. |
luislhl
approved these changes
Jan 8, 2025
msbrogli
approved these changes
Jan 9, 2025
This was referenced Jan 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The original test window for the transaction feature activation on testnet has passed.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged