Conversation
glevco
commented
Dec 11, 2024
|
Bencher Report| Branch | fix/update-acc-weight |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency nanoseconds (ns) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 88,938,177,557.60 (-10.79%) | 89,720,785,945.72 (100.88%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 88,938,177,557.60 (-10.79%) | 89,720,785,945.72 (100.88%) | 109,658,738,378.10 (81.10%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
- Coverage 84.95% 84.89% -0.07%
==========================================
Files 323 323
Lines 25115 25124 +9
Branches 3859 3859
==========================================
- Hits 21337 21328 -9
- Misses 3036 3050 +14
- Partials 742 746 +4 ☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Dec 11, 2024
msbrogli
previously approved these changes
Dec 11, 2024
msbrogli
approved these changes
Dec 11, 2024
jansegre
approved these changes
Dec 11, 2024
glevco
force-pushed
the
fix/update-acc-weight
branch
from
f42c4a7 to
4089a3d
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The recent typing change in the
meta.accumulated_weightintroduced a regression in theBaseTransaction.update_accumulated_weight()method. Its implementation was not updated to consider the change. Also, the/transaction_acc_weightAPI was changed to incorrectly return work instead of weight, making it a breaking change for clients.Acceptance Criteria
BaseTransaction.update_accumulated_weight()so it correctly compares work to the providedstop_value.update_accumulated_weight()call in the consensus which was passing the incorrectstop_value./transaction_acc_weightAPI so it returns the correct values (weight instead of work).Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged