chore(feature-activation): delay NOP feature#1187
Merged
Conversation
|
Bencher Report| Branch | chore/delay-no-feature |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 92,485,590,465.70 (-8.43%) | 90,899,109,118.44 (98.28%) | 111,098,911,144.76 (83.25%) |
jansegre
reviewed
Nov 25, 2024
glevco
force-pushed
the
chore/delay-no-feature
branch
from
ae86cfa to
2ccddda
Compare
jansegre
approved these changes
Nov 25, 2024
msbrogli
approved these changes
Nov 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 84.91% 84.89% -0.02%
==========================================
Files 323 323
Lines 25044 25044
Branches 3846 3846
==========================================
- Hits 21266 21262 -4
- Misses 3037 3039 +2
- Partials 741 743 +2 ☔ View full report in Codecov by Sentry. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Delay the configuration of the NOP feature configuration to test Feature Activation for Transactions, as the new hathor-core version has not been released yet.
Acceptance Criteria
events_simulatorCLI.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged