feat(p2p): Change sync-v2 main loop interval to one second#1184
Merged
feat(p2p): Change sync-v2 main loop interval to one second#1184
Conversation
jansegre
previously approved these changes
Nov 13, 2024
glevco
previously approved these changes
Nov 13, 2024
|
| Branch | feat/sync-v2-main-loop-interval |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency nanoseconds (ns) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 89,421,510,483.48 (-11.58%) | 91,019,433,369.52 (101.79%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 89,421,510,483.48 (-11.58%) | 91,019,433,369.52 (101.79%) | 111,245,974,118.30 (80.38%) |
8cef268 to
ab1022c
Compare
ab1022c to
881fcc3
Compare
jansegre
previously approved these changes
Nov 18, 2024
glevco
previously approved these changes
Nov 18, 2024
b0ac1f5 to
8a9fbb2
Compare
glevco
previously approved these changes
Nov 19, 2024
8a9fbb2 to
b53a41d
Compare
b53a41d to
d91513e
Compare
glevco
approved these changes
Nov 19, 2024
jansegre
approved these changes
Nov 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 84.89% 84.93% +0.04%
==========================================
Files 323 323
Lines 24984 24985 +1
Branches 3834 3834
==========================================
+ Hits 21210 21222 +12
+ Misses 3035 3028 -7
+ Partials 739 735 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The sync v2 main loop already have protection against multiple executions. But it just checks if it is running every 5 seconds per connection. We can safely reduce this interval to 1 second, speeding up the sync.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged