Skip to content

refactor: remove VertexStorageProtocol [part 4/11]#1164

Open
glevco wants to merge 1 commit intofeat/reactor-process-socketfrom
refactor/remove-vertex-storage-protocol
Open

refactor: remove VertexStorageProtocol [part 4/11]#1164
glevco wants to merge 1 commit intofeat/reactor-process-socketfrom
refactor/remove-vertex-storage-protocol

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Oct 23, 2024

Depends on #1163

Motivation

Previously, the VertexStorageProtocol was created during development of the Multiprocess Verification project, but as it's been on hold, that protocol is redundant and unnecessary.

For the P2P Multiprocess project, the traversal classes that currently use the VertexStorageProtocol will have to be callable from a subprocess, that is, it's storage calls will be though IPC. Since they only use the get_vertex method, I simplified them to only take exactly that. Then, I removed the VertexStorageProtocol as it was being used in only one other place (reward lock).

Acceptance Criteria

  • Change Reward Lock functions to take a TransactionStorage instead of a VertexStorageProtocol.
  • Change traversal classes to take a vertex_getter instead of a full VertexStorageProtocol.
  • Remove VertexStorageProtocol.
  • No changes in behavior.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 23, 2024
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch 2 times, most recently from a36b0c6 to 5234061 Compare October 23, 2024 03:59
@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/reactor-process-socket@a77aba6). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat/reactor-process-socket    #1164   +/-   ##
==============================================================
  Coverage                               ?   85.04%           
==============================================================
  Files                                  ?      326           
  Lines                                  ?    25123           
  Branches                               ?     3836           
==============================================================
  Hits                                   ?    21365           
  Misses                                 ?     3034           
  Partials                               ?      724           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@glevco glevco marked this pull request as ready for review October 23, 2024 13:59
@glevco glevco changed the title refactor: remove VertexStorageProtocol [part 5/8] refactor: remove VertexStorageProtocol [part 3/8] Oct 23, 2024
@glevco glevco force-pushed the feat/reactor-process-socket branch from 90e2208 to f746865 Compare October 27, 2024 21:24
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch from 5234061 to d421ece Compare October 27, 2024 21:25
@glevco glevco force-pushed the feat/reactor-process-socket branch from f746865 to 48e4120 Compare November 5, 2024 18:08
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch from d421ece to 4860168 Compare November 5, 2024 18:09
@glevco glevco changed the title refactor: remove VertexStorageProtocol [part 3/8] refactor: remove VertexStorageProtocol [part 4/10 Nov 6, 2024
@glevco glevco changed the title refactor: remove VertexStorageProtocol [part 4/10 refactor: remove VertexStorageProtocol [part 4/10] Nov 6, 2024
@glevco glevco force-pushed the feat/reactor-process-socket branch from 48e4120 to 25373c2 Compare November 6, 2024 15:19
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch from 4860168 to c32f145 Compare November 6, 2024 15:21
@glevco glevco force-pushed the feat/reactor-process-socket branch from 25373c2 to 2c9346f Compare November 7, 2024 01:57
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch from c32f145 to 07ecfc0 Compare November 7, 2024 01:58
@glevco glevco changed the title refactor: remove VertexStorageProtocol [part 4/10] refactor: remove VertexStorageProtocol [part 4/11] Nov 7, 2024
@glevco glevco force-pushed the feat/reactor-process-socket branch from 2c9346f to 72330e8 Compare November 8, 2024 15:44
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch from 07ecfc0 to b2ebfec Compare November 8, 2024 15:44
@glevco glevco force-pushed the feat/reactor-process-socket branch from 72330e8 to a77aba6 Compare November 25, 2024 16:12
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch from b2ebfec to 10cad8f Compare November 25, 2024 16:14
@glevco glevco force-pushed the refactor/remove-vertex-storage-protocol branch from 10cad8f to 2bcd22c Compare November 25, 2024 16:15
@jansegre jansegre mentioned this pull request Dec 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants