refactor: remove VertexStorageProtocol [part 4/11]#1164
Open
glevco wants to merge 1 commit intofeat/reactor-process-socketfrom
Open
refactor: remove VertexStorageProtocol [part 4/11]#1164glevco wants to merge 1 commit intofeat/reactor-process-socketfrom
glevco wants to merge 1 commit intofeat/reactor-process-socketfrom
Conversation
1 task
a36b0c6 to
5234061
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/reactor-process-socket #1164 +/- ##
==============================================================
Coverage ? 85.04%
==============================================================
Files ? 326
Lines ? 25123
Branches ? 3836
==============================================================
Hits ? 21365
Misses ? 3034
Partials ? 724 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
1 task
msbrogli
approved these changes
Oct 23, 2024
jansegre
approved these changes
Oct 23, 2024
90e2208 to
f746865
Compare
5234061 to
d421ece
Compare
f746865 to
48e4120
Compare
d421ece to
4860168
Compare
48e4120 to
25373c2
Compare
4860168 to
c32f145
Compare
25373c2 to
2c9346f
Compare
c32f145 to
07ecfc0
Compare
2c9346f to
72330e8
Compare
07ecfc0 to
b2ebfec
Compare
72330e8 to
a77aba6
Compare
b2ebfec to
10cad8f
Compare
10cad8f to
2bcd22c
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1163
Motivation
Previously, the
VertexStorageProtocolwas created during development of the Multiprocess Verification project, but as it's been on hold, that protocol is redundant and unnecessary.For the P2P Multiprocess project, the traversal classes that currently use the
VertexStorageProtocolwill have to be callable from a subprocess, that is, it's storage calls will be though IPC. Since they only use theget_vertexmethod, I simplified them to only take exactly that. Then, I removed theVertexStorageProtocolas it was being used in only one other place (reward lock).Acceptance Criteria
TransactionStorageinstead of aVertexStorageProtocol.vertex_getterinstead of a fullVertexStorageProtocol.VertexStorageProtocol.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged