refactor: move can_validate_full method [part 2/8]#1153
Merged
Conversation
glevco
force-pushed
the
refactor/move-can-validate-full
branch
from
37477f3 to
b6430fe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 84.45% 84.42% -0.04%
==========================================
Files 317 317
Lines 24368 24357 -11
Branches 3708 3705 -3
==========================================
- Hits 20581 20564 -17
Misses 3074 3074
- Partials 713 719 +6 ☔ View full report in Codecov by Sentry. |
glevco
changed the title
1 task
glevco
force-pushed
the
refactor/p2p/simplify-factory
branch
from
48a4de4 to
c85752d
Compare
glevco
force-pushed
the
refactor/move-can-validate-full
branch
from
b6430fe to
409f3f3
Compare
|
Bencher Report| Branch | refactor/move-can-validate-full |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,469,293,016.44 (-0.39%) | 91,681,483,508.09 (90.35%) | 112,055,146,509.89 (90.55%) |
glevco
changed the title
glevco
changed the title
glevco
force-pushed
the
refactor/move-can-validate-full
branch
from
409f3f3 to
8e980c1
Compare
jansegre
approved these changes
Oct 17, 2024
glevco
force-pushed
the
refactor/move-can-validate-full
branch
from
8e980c1 to
7dd0b6d
Compare
msbrogli
approved these changes
Oct 18, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1151
Motivation
As part of the P2P Multiprocess project, move a
BaseTransactionmethod that is used by the sync to the storage.Acceptance Criteria
can_validate_fullmethod fromBaseTransactiontoTransactionStorage.BaseTransaction.is_ready_for_validationmethod.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged