Skip to content

refactor(p2p): implement P2PDependencies class [part 6/11] #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glevco wants to merge 5 commits into
base: refactor/p2p/pre-ipc-refactors
Choose a base branch
from

refactor(p2p): implement P2P dependencies

1fff2ad
Select commit
Loading
Failed to load commit list.
Open

refactor(p2p): implement P2PDependencies class [part 6/11] #1152

refactor(p2p): implement P2P dependencies
1fff2ad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 5, 2026 in 0s

84.85% (target 82.00%)

View this Pull Request on Codecov

84.85% (target 82.00%)

Details

Codecov Report

❌ Patch coverage is 89.70037% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.85%. Comparing base (bfeacb5) to head (1fff2ad).
⚠️ Report is 13 commits behind head on refactor/p2p/pre-ipc-refactors.

Files with missing lines Patch % Lines
hathor/p2p/manager.py 82.24% 12 Missing and 7 partials ⚠️
hathor/p2p/dependencies/protocols.py 36.84% 0 Missing and 12 partials ⚠️
hathor/p2p/peer_connections.py 89.41% 7 Missing and 2 partials ⚠️
hathor/p2p/protocol.py 93.18% 2 Missing and 1 partial ⚠️
hathor/p2p/states/peer_id.py 57.14% 1 Missing and 2 partials ⚠️
hathor/reactor/reactor_socket_protocol.py 76.92% 3 Missing ⚠️
hathor/p2p/sync_v1/agent.py 93.10% 0 Missing and 2 partials ⚠️
hathor/builder/builder.py 90.00% 0 Missing and 1 partial ⚠️
hathor/p2p/states/hello.py 80.00% 0 Missing and 1 partial ⚠️
hathor/p2p/sync_v2/agent.py 96.77% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@                        Coverage Diff                         @@
##           refactor/p2p/pre-ipc-refactors    #1152      +/-   ##
==================================================================
+ Coverage                           84.84%   84.85%   +0.01%     
==================================================================
  Files                                 314      320       +6     
  Lines                               24335    24462     +127     
  Branches                             3708     3709       +1     
==================================================================
+ Hits                                20646    20757     +111     
- Misses                               2978     2990      +12     
- Partials                              711      715       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov