fix: event handling of txs with custom scripts#1140
Merged
Conversation
|
Bencher Report| Branch | fix/events/custom-script |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,388,384,397.32 (-0.65%) | 91,848,600,426.43 (90.59%) | 112,259,400,521.19 (90.32%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
- Coverage 84.42% 84.34% -0.08%
==========================================
Files 317 317
Lines 24291 24297 +6
Branches 3696 3697 +1
==========================================
- Hits 20507 20494 -13
- Misses 3068 3081 +13
- Partials 716 722 +6 ☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
Oct 2, 2024
jansegre
approved these changes
Oct 3, 2024
msbrogli
approved these changes
Oct 3, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's a bug in event handling when a tx spends another tx with a custom (or empty) script. This PR fixes this.
Acceptance Criteria
EMPTY_SCRIPTandCUSTOM_SCRIPT, with their respective tests.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged