feat: improve load-from-logs CLI command#1132
Merged
Conversation
|
| Report | Thu, September 5, 2024 at 15:22:31 UTC |
| Project | hathor-core |
| Branch | feat/improve-load-from-logs |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,409,921,726.48 (-0.77%) | 91,981,574,820.96 (90.70%) | 112,421,924,781.17 (90.20%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
jansegre
approved these changes
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
+ Coverage 84.39% 84.41% +0.01%
==========================================
Files 317 317
Lines 24240 24240
Branches 3684 3684
==========================================
+ Hits 20458 20462 +4
+ Misses 3069 3065 -4
Partials 713 713 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Sep 5, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
load-from-logsCLI command reads a raw logs file as outputted by a full node. This PR changes it so instead you have to process the log file with theparse-logscommand, only then to use it withload-from-logs. This makes the log files much smaller, as the parser strips every information but the vertex bytes.Also, previously that command only called
on_new_txin a loop, but didn't actually run the reactor or the full node itself. This PR also changes this.The new intended workflow would be something like this:
Acceptance Criteria
parse-logsCLI command.load-from-logsCLI command so it takes files fromparse-logsand so it actually runs a full node.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged