Skip to content

feat: enable cache by default#1125

Merged
glevco merged 1 commit intomasterfrom
feat/invert-cache-option
Sep 4, 2024
Merged

feat: enable cache by default#1125
glevco merged 1 commit intomasterfrom
feat/invert-cache-option

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 28, 2024

Motivation

We almost always run the full node with tx storage cache enabled, and running it without it is impractical for production. Therefore, we must invert the CLI option so cache is enabled by default.

Acceptance Criteria

  • Make cache be enabled by default, deprecating --cache and adding --disable-cache.
  • Set 100000 as the default value for cache size.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 28, 2024
@glevco glevco marked this pull request as ready for review August 28, 2024 21:42
jansegre
jansegre previously approved these changes Aug 28, 2024
jansegre
jansegre previously approved these changes Aug 28, 2024
@github-actions
Copy link

github-actions bot commented Aug 28, 2024

🐰Bencher

ReportTue, September 3, 2024 at 22:29:47 UTC
Projecthathor-core
Branchfeat/invert-cache-option
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,422,677,378.16 (-0.81%)92,027,490,789.67 (90.74%)112,478,044,298.49 (90.17%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

msbrogli
msbrogli previously approved these changes Aug 28, 2024
@glevco glevco dismissed stale reviews from msbrogli and jansegre via 23fb591 August 29, 2024 15:11
@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (f3e3ab5) to head (7a4f2db).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/builder/cli_builder.py 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
- Coverage   84.50%   84.36%   -0.15%     
==========================================
  Files         317      317              
  Lines       24231    24240       +9     
  Branches     3680     3684       +4     
==========================================
- Hits        20477    20449      -28     
- Misses       3050     3075      +25     
- Partials      704      716      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/invert-cache-option branch from 23fb591 to 7a4f2db Compare September 3, 2024 22:27
@glevco glevco merged commit 50ae3b2 into master Sep 4, 2024
@glevco glevco deleted the feat/invert-cache-option branch September 4, 2024 18:34
@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants