feat(event-queue): add tx data to VERTEX_REMOVED#1106
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 84.87% 84.95% +0.07%
==========================================
Files 314 314
Lines 23957 23951 -6
Branches 3621 3620 -1
==========================================
+ Hits 20334 20348 +14
+ Misses 2910 2896 -14
+ Partials 713 707 -6 ☔ View full report in Codecov by Sentry. |
|
| Report | Mon, August 12, 2024 at 18:41:18 UTC |
| Project | hathor-core |
| Branch | feat/event-queue/improve-tx-removed |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 104,014,644,026.32 (-9.12%) | 91,563,916,346.92 (88.03%) | 137,345,874,520.38 (75.73%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
glevco
force-pushed
the
feat/event-queue/improve-tx-removed
branch
from
5adecbd to
900550a
Compare
msbrogli
previously approved these changes
Aug 6, 2024
jansegre
approved these changes
Aug 7, 2024
msbrogli
approved these changes
Aug 9, 2024
glevco
force-pushed
the
feat/event-queue/improve-tx-removed
branch
from
9a42b1f to
5918385
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our main Event Queue use case (wallet-service) asked us to provide the whole vertex in the
VERTEX_REMOVEDevent data, instead of just the vertex ID.Acceptance Criteria
VERTEX_REMOVEDevent to useTxDataWithoutMetainstead ofVertexIdData.VertexIdDataas it's not used anymore.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged